Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: Give a better error message if node isn't installed #110114

Merged
merged 1 commit into from
Apr 10, 2023
Merged

compiletest: Give a better error message if node isn't installed #110114

merged 1 commit into from
Apr 10, 2023

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 9, 2023

No description provided.

@jyn514
Copy link
Member Author

jyn514 commented Apr 9, 2023

@bors rollup

@rustbot
Copy link
Collaborator

rustbot commented Apr 9, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 9, 2023
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+

@bors
Copy link
Contributor

bors commented Apr 9, 2023

📌 Commit 7ca7c8f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 9, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#110114 - jyn514:wasm-errors, r=compiler-errors
9f3a751 
compiletest: Give a better error message if `node` isn't installed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2023
@bors
Auto merge of rust-lang#110127 - matthiaskrgr:rollup-6ui12x5, r=matth…
3c2e2dd 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#108843 (Instantiate instead of erasing binder when probing param methods)
 - rust-lang#109985 (Add little `is_test_crate` function)
 - rust-lang#110028 (Migrate `rustc_hir_analysis` to session diagnostic [Part 3])
 - rust-lang#110095 (Migrate remainder of rustc_ty_utils to `SessionDiagnostic`)
 - rust-lang#110108 (Add renaming of ignore-git to changelog)
 - rust-lang#110114 (compiletest: Give a better error message if `node` isn't installed)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dd5942d into rust-lang:master Apr 10, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 10, 2023
@jyn514 jyn514 deleted the wasm-errors branch April 10, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jyn514 @rustbot @compiler-errors @bors @albertlarsan68