Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codegen tests for issues fixed by LLVM 16 #109895

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Add codegen tests for issues fixed by LLVM 16 #109895

merged 3 commits into from
Apr 12, 2023

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Apr 3, 2023

Fixes #75978.
Fixes #99960.
Fixes #101048.
Fixes #101082.
Fixes #101814.
Fixes #103132.
Fixes #103327.

@rustbot
Copy link
Collaborator

rustbot commented Apr 3, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 3, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikic
Copy link
Contributor Author

nikic commented Apr 5, 2023

Probably more for...

r? @cuviper

@rustbot rustbot assigned cuviper and unassigned Mark-Simulacrum Apr 5, 2023
@cuviper
Copy link
Member

cuviper commented Apr 11, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 11, 2023

📌 Commit 73f40d4 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 11, 2023
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 11, 2023
@JohnTitor
Rollup merge of rust-lang#109895 - nikic:llvm-16-tests, r=cuviper
efb96af 
Add codegen tests for issues fixed by LLVM 16

Fixes rust-lang#75978.
Fixes rust-lang#99960.
Fixes rust-lang#101048.
Fixes rust-lang#101082.
Fixes rust-lang#101814.
Fixes rust-lang#103132.
Fixes rust-lang#103327.
@JohnTitor
Copy link
Member

Failed in rollup: #110167 (comment)
@bors r- rollup=iffy

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 11, 2023
@nikic
Add ignore-debug to two tests
ec635c0 
These don't optimize with debug assertions. For one of them, this
is due to the new alignment checks, for the other I'm not sure
what specifically blocks it.
@nikic
Copy link
Contributor Author

nikic commented Apr 11, 2023

Looks like the usual issue with stdlib compiled with debug assertions.

@bors r=cuviper

@bors
Copy link
Contributor

bors commented Apr 11, 2023

📌 Commit ec635c0 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 11, 2023
@bors
Copy link
Contributor

bors commented Apr 11, 2023

⌛ Testing commit ec635c0 with merge b9b5c780022567a57116eac5aac80005e35a4ced...

@bors
Copy link
Contributor

bors commented Apr 11, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 11, 2023
@nikic
Copy link
Contributor Author

nikic commented Apr 11, 2023

Next try with a fix for 32-bit...

@bors r=cuviper

@bors
Copy link
Contributor

bors commented Apr 11, 2023

📌 Commit 83f525c has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 12, 2023

⌛ Testing commit 83f525c with merge 13d1802...

@bors
Copy link
Contributor

bors commented Apr 12, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 13d1802 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 12, 2023
@bors bors merged commit 13d1802 into rust-lang:master Apr 12, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 12, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (13d1802): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)		 -1.3% [-3.8%, -0.5%] 7
Improvements ✅
(secondary)		 -2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) -1.3% [-3.8%, -0.5%] 7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.8%, 0.8%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-0.7%, -0.5%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.7%, 0.8%] 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.70.0
8 participants
@nikic @rustbot @rust-log-analyzer @cuviper @bors @JohnTitor @rust-timer @Mark-Simulacrum