Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #109465

Closed
wants to merge 25 commits into from

Commits on Mar 15, 2023

  1. Configuration menu
    Copy the full SHA
    bdefcf5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee0513c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Configuration menu
    Copy the full SHA
    27e9ee9 View commit details
    Browse the repository at this point in the history
  2. refactor fn bootstrap::builder::Builder::compiler_for

    - check compiler stage before forcing for stage2.
    - check if download_rustc is not set before forcing for stage1.
    
    Signed-off-by: ozkanonur <[email protected]>
    onur-ozkan committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    2ec7f6c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. Configuration menu
    Copy the full SHA
    c9ddb73 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b4e17a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Configuration menu
    Copy the full SHA
    05b5046 View commit details
    Browse the repository at this point in the history
  2. adapt tests/codegen/vec-shrink-panik for LLVM 17

    After llvm/llvm-project@0d4a709
    LLVM now doesn't generate references to panic_cannot_unwind:
    
    @nikic:
    https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/a.20couple.20codegen.20test.20failures.20after.20llvm.200d4a709bb876824a/near/342664944
    >Okay, so LLVM now realizes that double panic is not possible, so that's fine.
    krasimirgg committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e4a4064 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    12c1385 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab1573a View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. new solver cleanup + coherence

    lcnr committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    47f24a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    938434a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a7ec045 View commit details
    Browse the repository at this point in the history
  4. woops

    lcnr committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f86b035 View commit details
    Browse the repository at this point in the history
  5. Ignore the vendor directory for tidy tests.

    When running `x.py test` on a downloaded source distribution (e.g.
    https://static.rust-lang.org/dist/rustc-<version>-src.tar.gz), the
    crates in the vendor directory contain a number of executable files that
    cause the tidy test to fail with the following message:
    
    tidy error: binary checked into source: <path>
    
    I see 26 such errors with the 1.68.0 source distribution. A few of these
    are .rs source files with incorrect executable permission, but most are
    scripts that are correctly marked executable.
    jfgoog committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    7571808 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    293f21c View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#106704 - ecnelises:big_archive, r=workingju…

    …bilee
    
    Support AIX-style archive type
    
    Reading facility of AIX big archive has been supported by `object` since 0.30.0.
    
    Writing facility of AIX big archive has already been supported by `ar_archive_writer`, but we need to bump the version to support the new archive type enum.
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e72ad51 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#109179 - llogiq:intrinsically-option-as-sli…

    …ce, r=eholk
    
    move Option::as_slice to intrinsic
    
    ``@scottmcm`` suggested on rust-lang#109095 I use a direct approach of unpacking the operation in MIR lowering, so here's the implementation.
    
    cc ``@nikic`` as this should hopefully unblock rust-lang#107224 (though perhaps other changes to the prior implementation, which I left for bootstrapping, are needed).
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    98bc283 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#109203 - Ezrashaw:refactor-ident-parsing, r…

    …=Nilstrieb
    
    refactor/feat: refactor identifier parsing a bit
    
    \+ error recovery for `expected_ident_found`
    
    Prior art: rust-lang#108854
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    7ce2aab View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#109295 - ozkanonur:issue-109286, r=ozkanonur

    refactor `fn bootstrap::builder::Builder::compiler_for` logic
    
    - check compiler stage before forcing for stage2.
    - check if download_rustc is not set before forcing for stage1.
    
    resolves rust-lang#109286
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    69d989b View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#109394 - krasimirgg:llvm-17-vec-panic, r=nikic

    adapt tests/codegen/vec-shrink-panik for LLVM 17
    
    After llvm/llvm-project@0d4a709 LLVM now doesn't generate references to panic_cannot_unwind:
    https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/17978#0186ff55-ca6f-4bc5-b1ec-2622c77d0ed5/744-746
    
    Adapted as suggested by ```@nikic``` on Zulip:
    https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/a.20couple.20codegen.20test.20failures.20after.20llvm.200d4a709bb876824a/near/342664944
    >Okay, so LLVM now realizes that double panic is not possible, so that's fine.
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0710ccb View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#109412 - GuillaumeGomez:add-gui-test, r=not…

    …riddle
    
    rustdoc: Add GUI test for "Auto-hide item contents for large items" setting
    
    Part of rust-lang#66181.
    
    The `browser-ui-test` version update is because there wasn't `null` check for attributes so I added it (PR is [here](GuillaumeGomez/browser-UI-test#440)).
    
    r? `@notriddle`
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ad2ced5 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#109423 - fmease:iat-selection-erase-regions…

    …-in-self-ty, r=compiler-errors
    
    Use region-erased self type during IAT selection
    
    Split off from rust-lang#109410 as discussed.
    Fixes rust-lang#109299.
    
    Re UI test: I use a reproducer of rust-lang#109299 that contains a name resolution error instead of reproducer [`regionck-2.rs`](https://github.com/rust-lang/rust/blob/fc7ed4af165c27ab5914b93251194f826920cc65/tests/ui/associated-inherent-types/regionck-2.rs) (as found in the `AliasKind::Inherent` PR) since it would (incorrectly) pass typeck in this PR due to the lack of regionck and I'd rather not make *that* a regression test (with or without `known-bug`).
    
    `@rustbot` label F-inherent_associated_types
    
    r? `@compiler-errors`
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    689f694 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#109447 - lcnr:coherence, r=compiler-errors

    new solver cleanup + implement coherence
    
    the cleanup:
    - change `Certainty::unify_and` to consider ambig + overflow to be ambig
    - rename `trait_candidate_should_be_dropped_in_favor_of` to `candidate_should_be_dropped_in_favor_of`
    - remove outdated fixme
    
    For coherence I mostly just add an ambiguous candidate if the current trait ref is unknowable. I am doing the same for reservation impl where I also just add an ambiguous candidate.
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1ead586 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#109452 - jfgoog:ignore-vendor, r=ozkanonur

    Ignore the vendor directory for tidy tests.
    
    When running `x.py test` on a downloaded source distribution (e.g. https://static.rust-lang.org/dist/rustc-<version>-src.tar.gz), the crates in the vendor directory contain a number of executable files that cause the tidy test to fail with the following message:
    
    tidy error: binary checked into source: <path>
    
    I see 26 such errors with the 1.68.0 source distribution. A few of these are .rs source files with incorrect executable permission, but most are scripts that are correctly marked executable.
    matthiaskrgr authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e3f31bc View commit details
    Browse the repository at this point in the history