Enable MIR reference propagation by default

[cjgillot]

No description provided.

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 0e79ec528b5a36066b54dcdde7609d24b34d964a with merge 381b17270653ca5b617ae9534bf8d5b10217ec33...

[bors]

☀️ Try build successful - checks-actions
Build commit: 381b17270653ca5b617ae9534bf8d5b10217ec33 (381b17270653ca5b617ae9534bf8d5b10217ec33)

[rust-timer]

Finished benchmarking commit (381b17270653ca5b617ae9534bf8d5b10217ec33): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 3.3%]	38
Regressions ❌ (secondary)	1.1%	[0.1%, 9.2%]	30
Improvements ✅ (primary)	-0.4%	[-1.0%, -0.2%]	5
Improvements ✅ (secondary)	-0.6%	[-1.1%, -0.3%]	10
All ❌✅ (primary)	0.4%	[-1.0%, 3.3%]	43

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[0.3%, 3.8%]	3
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-5.0%	[-10.4%, -1.4%]	4
Improvements ✅ (secondary)	-1.6%	[-3.0%, -1.1%]	5
All ❌✅ (primary)	-2.0%	[-10.4%, 3.8%]	7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.7%, 3.7%]	6
Regressions ❌ (secondary)	4.6%	[2.0%, 6.0%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[0.7%, 3.7%]	6

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit e1827fd5af1cb9c5e0985a1fe93d84e9e6f2135a with merge 6be4d270af9df70be9fab0ec56f43bed4289347b...

[bors]

☀️ Try build successful - checks-actions
Build commit: 6be4d270af9df70be9fab0ec56f43bed4289347b (6be4d270af9df70be9fab0ec56f43bed4289347b)

[rust-timer]

Finished benchmarking commit (6be4d270af9df70be9fab0ec56f43bed4289347b): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.2%, 3.6%]	58
Regressions ❌ (secondary)	0.9%	[0.1%, 1.8%]	32
Improvements ✅ (primary)	-0.9%	[-1.1%, -0.7%]	2
Improvements ✅ (secondary)	-0.6%	[-1.2%, -0.3%]	7
All ❌✅ (primary)	0.5%	[-1.1%, 3.6%]	60

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[0.2%, 6.6%]	5
Regressions ❌ (secondary)	3.6%	[1.5%, 5.7%]	2
Improvements ✅ (primary)	-6.6%	[-9.9%, -2.2%]	3
Improvements ✅ (secondary)	-3.7%	[-4.3%, -3.1%]	2
All ❌✅ (primary)	-0.7%	[-9.9%, 6.6%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	4.2%	[1.6%, 5.5%]	3
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[-0.9%, 3.7%]	2

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit bb6826db6835630fa6b8f942bafe98b2d0641e83 with merge a90f804c6fcccefc97feabe90c268c2fcbdb8f7f...

[cjgillot]

@bors r=JakobDegen

[bors]

📌 Commit a5031d5 has been approved by JakobDegen

It is now in the queue for this repository.

[bors]

⌛ Testing commit a5031d5 with merge 8aa9929806f9d63ad43fe6d929cf11fdb9bd98b5...

[bors]

💔 Test failed - checks-actions

[cjgillot]

@bors r=JakobDegen

[bors]

📌 Commit f993c6d has been approved by JakobDegen

It is now in the queue for this repository.

[bors]

⌛ Testing commit f993c6d with merge 079e544...

[bors]

☀️ Test successful - checks-actions
Approved by: JakobDegen
Pushing 079e544 to master...

[rust-timer]

Finished benchmarking commit (079e544): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.5%, 2.5%]	15
Regressions ❌ (secondary)	0.8%	[0.2%, 1.3%]	7
Improvements ✅ (primary)	-0.9%	[-1.0%, -0.8%]	3
Improvements ✅ (secondary)	-0.6%	[-1.1%, -0.4%]	6
All ❌✅ (primary)	0.8%	[-1.0%, 2.5%]	18

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	8.0%	[3.4%, 12.5%]	2
Regressions ❌ (secondary)	3.4%	[1.9%, 6.5%]	4
Improvements ✅ (primary)	-2.5%	[-4.2%, -0.7%]	4
Improvements ✅ (secondary)	-3.7%	[-4.2%, -3.2%]	2
All ❌✅ (primary)	1.0%	[-4.2%, 12.5%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.8%, 1.8%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.8%	[-5.6%, -1.2%]	9
Improvements ✅ (secondary)	-5.1%	[-5.1%, -5.1%]	1
All ❌✅ (primary)	-2.0%	[-5.6%, 1.8%]	14

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.0%, 1.6%]	85
Regressions ❌ (secondary)	0.8%	[0.1%, 1.7%]	22
Improvements ✅ (primary)	-0.7%	[-4.7%, -0.0%]	11
Improvements ✅ (secondary)	-1.0%	[-1.8%, -0.0%]	15
All ❌✅ (primary)	0.2%	[-4.7%, 1.6%]	96

Bootstrap: 657.557s -> 658.756s (0.18%)

[pnkfelix]

visiting for perf-triage

• This is turning on a MIR pass at lower optimizations levels, so its expected that it would cause the compiler to do more work.
• its clear from the perf runs on the PR itself that the PR author already put in much effort to make the pass faster than it had started out.
• marking as triaged.

@rustbot label: +perf-regression-triaged