Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #108998

Merged
merged 22 commits into from
Mar 11, 2023
Merged

Rollup of 9 pull requests #108998

merged 22 commits into from
Mar 11, 2023

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    660d985 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Configuration menu
    Copy the full SHA
    4fe232b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Configuration menu
    Copy the full SHA
    3097453 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d223c26 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3aea469 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1b6d6f9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d4b59a0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9574f39 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f714613 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Configuration menu
    Copy the full SHA
    a30c2c2 View commit details
    Browse the repository at this point in the history
  2. updating comment

    Co-authored-by: Ruby Lazuli <[email protected]>
    lcnr and PatchMixolydic authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    14818e2 View commit details
    Browse the repository at this point in the history
  3. Update triagebot rust-analyzer team mention

    The working group got renamed
    Veykril authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    a818484 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ad2bcb5 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#106921 - madsmtm:cell-memory-layout, r=dtolnay

    Add documentation about the memory layout of `Cell`
    
    rust-lang#101717 guaranteed the memory layout of `UnsafeCell<T>`.
    
    This property (a guaranteed memory layout) can be useful to have on `Cell<T>` as well.
    
    (Note that `Cell<u8>` [already doesn't trigger the `improper_ctypes` lint](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=34af59ef60b96d8a8bdaec1d52cb5420) since it is `#[repr(transparent)]`).
    
    The concrete use-case is for the crate [`objc2`](https://github.com/madsmtm/objc2) to specify that `Cell<T>` is safe to use as an instance variable when `T` is.
    
    Fixes rust-lang#79303.
    
    ---
    
    I'm unsure if we should specify less, for example say that the `Cell` may have extra restrictions on when it may be accessed, or if that's implicit in the (deliberately minimal) way I've worded it here?
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    b90277e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#108828 - compiler-errors:new-solver-alias-e…

    …q-on-num-var, r=lcnr
    
    Emit alias-eq when equating numeric var and projection
    
    This doesn't fix everything having to do with projections and infer vars, but it does fix a common case I saw in HIR typeck.
    
    r? `@lcnr`
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    233ed35 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#108834 - compiler-errors:fn-ptr-fn-obl, r=s…

    …pastorino
    
    Do not ICE when we have fn pointer `Fn` obligations with bound vars in the self type
    
    We never supported solving `for<'a> fn(&'a ()): Fn(&'a ())` -- I tried to add that support in rust-lang#104929, but iirc `@lcnr` wanted to support this more generally by eagerly instantiating trait predicate binders with placeholders. That never happened due to blockers in the old solver, but we probably shouldn't ICE in any case.
    
    On the bright side, this passes on the new solver :^)
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    bee8473 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#108900 - bvanjoi:issue-108275, r=petrochenkov

    fix(lexer): print whitespace warning for \x0c
    
    - close rust-lang#108275
    - discussion: rust-lang#108403
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4ad3230 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#108930 - Ezrashaw:better-error-for-manual-f…

    …n-impl, r=petrochenkov
    
    feat: implement better error for manual impl of `Fn*` traits
    
    Fixes rust-lang#39259
    
    cc `@estebank` (you gave me some advice in the linked issue, would you like to review?)
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7699462 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#108937 - lcnr:winnowing-enum, r=WaffleLapkin

    improve readability of winnowing
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    772b1ce View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#108947 - compiler-errors:ct-infer-no-shapes…

    …hifting, r=BoxyUwU
    
    Don't even try to combine consts with incompatible types
    
    ~I left a more detailed explanation for why this fixes this issue in the UI test, but in general, we should not try to unify const infer vars and rigid consts if they have incompatible types. That's because we don't want something like a `ConstArgHasType` predicate to suddenly go from passing to failing, or vice versa, due to a shallow resolve.~
    
    1. Use the `type_of` for a parameter in `try_eval_lit_or_param`, instead of the "expected" type from a `WithOptConstParam` def id.
    2. Don't combine consts that have incompatible types.
    
    Fixes rust-lang#108781
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    145e620 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#108976 - Veykril:patch-2, r=jyn514

    Update triagebot rust-analyzer team mention
    
    The working group got renamed
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    42ca383 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#108983 - LeSeulArtichaut:108646-target-feat…

    …ure-default-impl, r=cjgillot
    
    Forbid `#[target_feature]` on safe default implementations
    
    Fixes rust-lang#108646.
    matthiaskrgr authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f74bb35 View commit details
    Browse the repository at this point in the history