Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiletest possible crash in option only-modified #108313

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

chenyukang
Copy link
Member

fixed files maybe removed, unwrap will crash in this scenario.

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Feb 21, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 21, 2023

📌 Commit 6e34e65 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 21, 2023
…d, r=oli-obk

Fix compiletest possible crash in option only-modified

`fixed` files maybe removed, `unwrap` will crash in this scenario.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 22, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#104239 (Better debug logs for borrowck constraint graph)
 - rust-lang#108202 (Make sure `test_type_match` doesn't ICE with late-bound types)
 - rust-lang#108295 (Use DefKind to give more item kind information during BindingObligation note )
 - rust-lang#108306 (compiletest: up deps)
 - rust-lang#108313 (Fix compiletest possible crash in option only-modified)
 - rust-lang#108322 (Clean ConstProp)
 - rust-lang#108323 (hir-analysis: make one diagnostic translatable)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c21b7f6 into rust-lang:master Feb 22, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants