-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #108127
Rollup of 7 pull requests #108127
Conversation
…ly for items with a path of 1 element
…se `#[doc(inline)]`
…O8Ki More accurate spans for arg removal suggestion Partially address rust-lang#106304.
…erge, r=notriddle Prevent some attributes from being merged with others on reexports Final fix for rust-lang#59368. As discussed on zulip [here](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Filtering.20sub.20attributes.20in.20ast.3A.3AAttribute), we need to clone the `Attribute` to be able to filter some parts of it. Then we need to go through the attributes to able to only keep what we want (everything except a few attributes in short). As for the second commit, when I wrote the test, I realized that the code to traverse all reexports one by one to collect all their attributes was not completely working so I fixed the few issues remaining. r? `@notriddle`
…, r=oli-obk `if $c:expr { Some($r:expr) } else { None }` =>> `$c.then(|| $r)` Resurrection of rust-lang#108079
…l, r=petrochenkov note issue for feature(packed_bundled_libs) Add to feature (introduced in rust-lang#105601) gate description number of issue created for it. r? `@petrochenkov`
…umeGomez use chars instead of strings where applicable
…compiler-errors Do not ICE on unmet trait alias bounds Rework of rust-lang#108093 following feedback on that PR. Fixes rust-lang#108072 r? `@compiler-errors`
…viewers, r=wesleywiser Add new people to the compiletest review rotation `@oli-obk` and `@wesleywiser` volunteered to be part of the review rotation of compiletest in https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202023-02-16/near/328274017
@bors r+ rollup=never p=7 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: c5d1b3ea96 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (9a7cc6c): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Successful merges:
if $c:expr { Some($r:expr) } else { None }
=>>$c.then(|| $r)
#108090 (if $c:expr { Some($r:expr) } else { None }
=>>$c.then(|| $r)
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup