Improve pretty-printing of HirIdValidator errors

[Swatinem]

This now uses node_to_string for both missing and seen Ids, which includes the snippet of code for which the Id was allocated. Also removes the duplicated printing of HirId, as node_to_string also includes that.

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[Swatinem]

Before:

ItemLocalIds not assigned densely in ::example. Max ItemLocalId = 22, missing IDs = [
    "[local_id: 3, owner: ::example]",
]; seens IDs = [
    "(HirId(DefId(0:6 ~ rust_out[ddcc]::example).0) fn example (hir_id=HirId(DefId(0:6 ~ rust_out[ddcc]::example).0)))",
    "(HirId(DefId(0:6 ~ rust_out[ddcc]::example).1) param x: &'a str (hir_id=HirId(DefId(0:6 ~ rust_out[ddcc]::example).1)))",
    "(HirId(DefId(0:6 ~ rust_out[ddcc]::example).2) pat x (hir_id=HirId(DefId(0:6 ~ rust_out[ddcc]::example).2)))",
    "(HirId(DefId(0:6 ~ rust_out[ddcc]::example).4) type async move { x.len() } (hir_id=HirId(DefId(0:6 ~ rust_out[ddcc]::example).4)))",

After:

ItemLocalIds not assigned densely in ::example. Max ItemLocalId = 22, missing IDs = [
    "unknown node (hir_id=HirId(DefId(0:3 ~ foo[b698]::example).3))",
]; seen IDs = [
    "fn example (hir_id=HirId(DefId(0:3 ~ foo[b698]::example).0))",
    "param x: &'a str (hir_id=HirId(DefId(0:3 ~ foo[b698]::example).1))",
    "pat x (hir_id=HirId(DefId(0:3 ~ foo[b698]::example).2))",
    "type async move { x.len() } (hir_id=HirId(DefId(0:3 ~ foo[b698]::example).4))",

[eggyal]

Is the "before" example in #107515 (comment) correct? It too shows the code snippet—indeed it looks like it contains the same information as in the "after" example (albeit with the duplication you mention), except in the latter the layout/order has become a little more difficult for my brain to parse?

[Swatinem]

The code snippet was there before, though the format was rather ($hirid $codesnippet ($hirid)) so the id was duplicated. The code snippet was not present in the "missing IDs" before.

[Noratrieb]

Printing the HirIds first as before looks way more readable to me since they are aligned. I think we should delete the trailing HirId instead.

[Swatinem]

I completely changed the node_to_string output now. It will always print the HirId first, and then info about the item. I also cleanup up other users which similarly were printing the ID multiple times.

This means that all the output (I only found bug! and debug! output) that was using this will change as well!

Let me try to capture another example later, as I already fixed the case where I was running into this.

[Swatinem]

Now looks like this:

ItemLocalIds not assigned densely in ::example. Max ItemLocalId = 24, missing IDs = [
    "HirId(DefId(0:4 ~ foo[b698]::example).4) (unknown node)",
]; seen IDs = [
    "HirId(DefId(0:4 ~ foo[b698]::example).0) (fn example)",
    "HirId(DefId(0:4 ~ foo[b698]::example).1) (param `x: &'a str`)",
    "HirId(DefId(0:4 ~ foo[b698]::example).2) (pat `x`)",
    "HirId(DefId(0:4 ~ foo[b698]::example).3) (expr `async move { x.len() }`)",
    "HirId(DefId(0:4 ~ foo[b698]::example).5) (type `async move { x.len() }`)",

[compiler-errors]

Cool, given that this is internal-only, I'm happy with merging this now. I'll approve once CI is green.

[compiler-errors]

@bors r+ rollup

[bors]

📌 Commit 3a75f10 has been approved by compiler-errors

It is now in the queue for this repository.