Rollup of 11 pull requests #107451

matthiaskrgr · 2023-01-29T19:03:40Z

Successful merges:

Fix maintainer validation message #96763 (Fix maintainer validation message)
Insert whitespace to avoid ident concatenation in suggestion #106540 (Insert whitespace to avoid ident concatenation in suggestion)
print why a test was ignored if its the only test specified #106763 (print why a test was ignored if its the only test specified)
libtest: Print why a test was ignored if it's the only test specified. #106769 (libtest: Print why a test was ignored if it's the only test specified.)
Implement signum with Ord #106798 (Implement signum with Ord)
Output tree representation on thir-tree #107006 (Output tree representation on thir-tree)
Update wording of invalid_doc_attributes docs. #107078 (Update wording of invalid_doc_attributes docs.)
Pass --locked to the x test tidy call #107169 (Pass --locked to the x test tidy call)
docs: remove colon from time header #107431 (docs: remove colon from time header)
rustdoc: remove unused class has-srclink #107432 (rustdoc: remove unused class has-srclink)
When stamp doesn't exist, should say Error, and print path to stamp file #107448 (When stamp doesn't exist, should say Error, and print path to stamp file)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

This allows to fail the push when the `Cargo.lock` file needs to be updated.

fix remove token check for maintainers fix: rm validate_maintainers function

It's not used anywhere else; the inconsistency is weird.

Stopped being used in CSS with 73d0f7c

…lacrum Fix maintainer validation message State clearly why maintainer verification is not activating, ruling out the user thinking they misconfigured something.

…, r=cjgillot Insert whitespace to avoid ident concatenation in suggestion This PR tweaks the suggestion of removing misplaced parentheses around trait bounds so as to avoid concatenating two identifiers. Although subtle, this should make outputs less surprising especially when applying the `MachineApplicable` suggestions automatically.

…s_ignored_if_its_the_only_test_specified, r=Mark-Simulacrum print why a test was ignored if its the only test specified Fixes [rust-lang#106659](rust-lang#106659)

…as_ignored_if_its_the_only_test_specified, r=Mark-Simulacrum libtest: Print why a test was ignored if it's the only test specified. Fixes [rust-lang#106659](rust-lang#106659) Needed by [106763](rust-lang#106763)

…mulacrum Implement `signum` with `Ord` Rather than needing to do things like rust-lang#105840 for `signum` too, might as well just implement that method using `Ord`, since it's doing the same "I need `-1`/`0`/`+1`" behaviour that `cmp` is already doing. This also seems to slightly improve the assembly: <https://rust.godbolt.org/z/5oEEqbxK1>

Output tree representation on thir-tree The current output of `-Zunpretty=thir-tree` is really cumbersome to work with, using an actual tree representation should make it easier to see what the thir looks like.

… r=jackh726 Update wording of invalid_doc_attributes docs. There was a typo in the original docs for `invalid_doc_attributes`. I felt it could use a little rewording to try to clarify the reasoning for the lint. Also, this adds the future-incompatible notice.

…=Mark-Simulacrum Pass `--locked` to the x test tidy call This allows to fail the push when the `Cargo.lock` file needs to be updated.

docs: remove colon from time header It's not used anywhere else; the inconsistency is weird.

…=GuillaumeGomez rustdoc: remove unused class `has-srclink` Stopped being used in CSS with 73d0f7c.

…ark-Simulacrum When stamp doesn't exist, should say Error, and print path to stamp file Follow up pr for rust-lang#107397

matthiaskrgr · 2023-01-29T19:03:51Z

@bors r+ rollup=never p=11

bors · 2023-01-29T19:03:53Z

📌 Commit 97e6aba has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-01-29T19:29:53Z

⌛ Testing commit 97e6aba with merge e972bc8...

bors · 2023-01-29T22:14:10Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e972bc8 to master...

rust-timer · 2023-01-29T22:17:15Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#107448	765fc6488a01e0ddb0d0b43b094c5f539fd27d11
#107432	f09d100de956316b8406a762c367561b6c9285c3
#107431	be291f085897f71e1ea9a91c34300f7b6c28bd45
#107169	b55ef41ce10c66daf3dc5fb9df34c18c3cbce77f
#107078	876264720a71606100d08d893a51f15bcada0e54
#107006	c14ca0e04a7317fdb8a907529312b16605762aff
#106798	1063a4f6b02d6a9c9a0acb4008796a8421ad3dcb
#106769	775fffd79d90baf5bae55b94fedc1639043ecbb2
#106763	3ad6b96e09cc708d673152ab2857bbeb920e49ec
#106540	1cabeb70c9111db0781041543da227823c3cea7c
#96763	e5c1fa375f8f0fa47b9b5873241cdc32f30fbab3

previous master: c7bf469fec

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-01-29T23:34:05Z

Finished benchmarking commit (e972bc8): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[3.0%, 3.7%]	2
Regressions ❌ (secondary)	2.8%	[1.2%, 4.5%]	2
Improvements ✅ (primary)	-3.4%	[-5.7%, -2.3%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-5.7%, 3.7%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.3%	[-4.5%, -1.4%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.3%	[-4.5%, -1.4%]	7

Move THIR printing to rustc_mir_build. rust-lang#107451 increased the compilation time of `rustc_middle` by 10% = 3s. As rust-lang#107006 adds quite a lot of code to rustc_middle, I suspect it to be the cause. This PR moves the THIR printing code to `rustc_mir_build`, where the query provider lives, in order to benefit from higher parallelism when compiling rustc.

Move THIR printing to rustc_mir_build. rust-lang/rust#107451 increased the compilation time of `rustc_middle` by 10% = 3s. As rust-lang/rust#107006 adds quite a lot of code to rustc_middle, I suspect it to be the cause. This PR moves the THIR printing code to `rustc_mir_build`, where the query provider lives, in order to benefit from higher parallelism when compiling rustc.

scottmcm and others added 25 commits January 12, 2023 22:39

Implement signum with Ord

fcbc12e

Update wording of invalid_doc_attributes docs.

66f60e5

Pass --locked to the x test tidy call

78db9ee

This allows to fail the push when the `Cargo.lock` file needs to be updated.

fix maintainer validation message

2fe58b9

fix remove token check for maintainers fix: rm validate_maintainers function

Print why a test was ignored if it's the only test specified.

7713337

Print why a test was ignored if it's the only test specified.

002dbbe

output tree representation for thir-tree

90e4c13

add test

3bce66f

previous thir unpretty output through thir-flat

9438126

address review

92f2d27

docs: remove colon from time header

2cdec46

It's not used anywhere else; the inconsistency is weird.

rustdoc: remove unused class has-srclink

74e843c

Stopped being used in CSS with 73d0f7c

Insert whitespace to avoid ident concatenation in suggestion

807ebac

When stamp doesn't exist, should say Error, and print path to stamp file

770d303

Rollup merge of rust-lang#96763 - Abdur-rahmaanJ:patch-1, r=Mark-Simu…

309fb19

…lacrum Fix maintainer validation message State clearly why maintainer verification is not activating, ruling out the user thinking they misconfigured something.

Rollup merge of rust-lang#106763 - lenko-d:106659-Print_why_a_test_wa…

94809b3

…s_ignored_if_its_the_only_test_specified, r=Mark-Simulacrum print why a test was ignored if its the only test specified Fixes [rust-lang#106659](rust-lang#106659)

Rollup merge of rust-lang#107006 - b-naber:thir-tree, r=jackh726

4544682

Output tree representation on thir-tree The current output of `-Zunpretty=thir-tree` is really cumbersome to work with, using an actual tree representation should make it easier to see what the thir looks like.

Rollup merge of rust-lang#107169 - albertlarsan68:lock-in-pre-push, r…

6ce862c

…=Mark-Simulacrum Pass `--locked` to the x test tidy call This allows to fail the push when the `Cargo.lock` file needs to be updated.

Rollup merge of rust-lang#107431 - notriddle:notriddle/colon, r=thomcc

3922654

docs: remove colon from time header It's not used anywhere else; the inconsistency is weird.

Rollup merge of rust-lang#107432 - notriddle:notriddle/has-srclink, r…

dd315fd

…=GuillaumeGomez rustdoc: remove unused class `has-srclink` Stopped being used in CSS with 73d0f7c.

Rollup merge of rust-lang#107448 - Teapot4195:pr-107397-followup, r=M…

97e6aba

…ark-Simulacrum When stamp doesn't exist, should say Error, and print path to stamp file Follow up pr for rust-lang#107397

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 29, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2023

bors merged commit e972bc8 into rust-lang:master Jan 29, 2023

rustbot added this to the 1.69.0 milestone Jan 29, 2023

This was referenced Jan 29, 2023

Add kernel-address sanitizer support for freestanding targets #99679

Merged

Add -Z instrument-xray flag #102963

Merged

make ty::Ty: Debug not call the Display impl #107084

Closed

cjgillot mentioned this pull request Feb 26, 2023

Move THIR printing to rustc_mir_build. #108493

Merged

matthiaskrgr deleted the rollup-m4ucfu8 branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 11 pull requests #107451

Rollup of 11 pull requests #107451

matthiaskrgr commented Jan 29, 2023

matthiaskrgr commented Jan 29, 2023

bors commented Jan 29, 2023

bors commented Jan 29, 2023

bors commented Jan 29, 2023

rust-timer commented Jan 29, 2023

rust-timer commented Jan 29, 2023

Rollup of 11 pull requests #107451

Rollup of 11 pull requests #107451

Conversation

matthiaskrgr commented Jan 29, 2023

matthiaskrgr commented Jan 29, 2023

bors commented Jan 29, 2023

bors commented Jan 29, 2023

bors commented Jan 29, 2023

rust-timer commented Jan 29, 2023

rust-timer commented Jan 29, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles