Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_metadata: Encode the set of "rustdoc-reachable" def ids to metadata #107237

Closed
wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

rustdoc currently calculates this set for every crate in the crate tree, so let's try to pre-compute it in advance.

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 23, 2023
@petrochenkov
Copy link
Contributor Author

Initial version without any caching.
@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 23, 2023
@bors
Copy link
Contributor

bors commented Jan 23, 2023

⌛ Trying commit d31d71e with merge 0f312812bb875cfde5e43719e27535fbd4580a30...

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2023
@bors
Copy link
Contributor

bors commented Jan 23, 2023

☀️ Try build successful - checks-actions
Build commit: 0f312812bb875cfde5e43719e27535fbd4580a30 (0f312812bb875cfde5e43719e27535fbd4580a30)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0f312812bb875cfde5e43719e27535fbd4580a30): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.5%, 1.4%] 17
Regressions ❌
(secondary)
1.0% [0.4%, 1.9%] 10
Improvements ✅
(primary)
-1.3% [-4.1%, -0.2%] 15
Improvements ✅
(secondary)
-2.6% [-3.9%, -0.8%] 22
All ❌✅ (primary) -0.2% [-4.1%, 1.4%] 32

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [0.9%, 1.4%] 5
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-3.2%, -1.3%] 4
Improvements ✅
(secondary)
-2.7% [-3.8%, -2.0%] 4
All ❌✅ (primary) -0.4% [-3.2%, 1.4%] 9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.5% [1.5%, 1.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-3.2%, -1.8%] 4
Improvements ✅
(secondary)
-3.2% [-3.9%, -2.0%] 14
All ❌✅ (primary) -1.6% [-3.2%, 1.5%] 5

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 24, 2023
@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 24, 2023
@petrochenkov
Copy link
Contributor Author

This is another tradeoff in favor of rustdoc at cost of rustc, and it makes less sense after #94857 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants