-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_metadata: Encode the set of "rustdoc-reachable" def ids to metadata #107237
Conversation
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
Initial version without any caching. |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit d31d71e with merge 0f312812bb875cfde5e43719e27535fbd4580a30... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (0f312812bb875cfde5e43719e27535fbd4580a30): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This is another tradeoff in favor of rustdoc at cost of rustc, and it makes less sense after #94857 is merged. |
rustdoc
currently calculates this set for every crate in the crate tree, so let's try to pre-compute it in advance.