Update the version of musl used on `*-linux-musl` targets to 1.2.3 #107129

wesleywiser · 2023-01-20T21:04:12Z

Update the version of musl used on our Linux musl targets from 1.1.24 to 1.2.3 as proposed in rust-lang/compiler-team#572. musl 1.2.3 is the latest version of musl and supports the same range of Linux kernels as the 1.1 series. As such, it does not affect the minimum supported version of Linux for any of the musl targets.

One of the major musl 1.2 features is support for time64. This support is both source and ABI compatible with programs built against musl 1.1 and so updating the musl version for these targets should not cause Rust programs to fail to run or compile (a crater run has been completed which demonstrates this for the i686-unknown-linux-musl target).

Once this change reaches stable, the libc crate will then be able to update their definitions to support 64-bit time, matching the default musl 1.2 APIs exactly.

Fixes #91178

wesleywiser · 2023-01-20T22:56:05Z

@bors try

bors · 2023-01-20T22:56:14Z

⌛ Trying commit 97795b0aa4815fd51e46b1702da9fa34e84863fa with merge a40ec913238f4f188d97c41aa605cb486451acf2...

bors · 2023-01-21T01:38:58Z

☀️ Try build successful - checks-actions
Build commit: a40ec913238f4f188d97c41aa605cb486451acf2 (a40ec913238f4f188d97c41aa605cb486451acf2)

wesleywiser · 2023-01-26T19:51:08Z

@craterbot run mode=build-and-test name=musl_1_2_upgrade_i686_unknown_linux_musl start=try#d5830e3d3b571fe52cdf4b7b34be99be74dc65ea+target=i686-unknown-linux-musl end=try#a40ec913238f4f188d97c41aa605cb486451acf2+target=i686-unknown-linux-musl

craterbot · 2023-01-26T19:51:13Z

👌 Experiment musl_1_2_upgrade_i686_unknown_linux_musl created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-01-26T19:52:02Z

🚧 Experiment musl_1_2_upgrade_i686_unknown_linux_musl is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-01-27T19:45:49Z

🎉 Experiment musl_1_2_upgrade_i686_unknown_linux_musl is completed!
📊 99 regressed and 94 fixed (253665 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

wesleywiser · 2023-01-27T23:45:41Z

Crater reports 76 root regressions:

5 are build failures due to running out of disk space during the build.
71 are test failures.
- 9 are SIGSEGV: invalid memory reference or SIGBUS: access to undefined memory caused by UB in the crate.
  - miri test finds the UB in most of the crates except for a few which use FFI before the test crashes.
- 32 are assertion failures of some variety
  - Lots of different issues, tests asserting non-deterministic things like hashmap iteration order, using random data generators, tests expecting stdout to be hooked to a terminal, etc.
  - I sampled ~14 failures that looked interesting but did not manually validate the rest. I did not find any actual regressions in the cases I examined.
- 8 are various kinds of timeout failures, test took too long, etc.
  - I could not reproduce any of these failures.
- 22 are from OS level errors such as "file not found", "connection refused", etc.
  - All failures in this category were not reproducible or showed the tests as flaky because they periodically failed before and after this change.

I believe the crater results show that updating our musl targets from musl 1.1.24 to musl 1.2.3 will not cause ecosystem breakage which is consistent with the release notes from upstream.

lqd · 2023-05-08T19:53:14Z

I also think it's keccak / cranelift-codegen currently being noisy, and have seen that in other PRs.

@rustbot label: +perf-regression-triaged

alex · 2023-05-09T22:25:22Z

This is perhaps a dumb question, but does this mean that, starting with rustc 1.71, binaries compiled by rustc will no longer work on musl 1.1 targets?

NobodyXu · 2023-05-10T03:43:37Z

This is perhaps a dumb question, but does this mean that, starting with rustc 1.71, binaries compiled by rustc will no longer work on musl 1.1 targets?

AFAIK musl is statically linked anyway, so it probably won't matter

alex · 2023-05-10T03:46:06Z

That's the default, but what about -Ctarget-feature=-crt-static builds (i.e., those intended for use on Alpine or other distros where musl is the system libc).

NobodyXu · 2023-05-10T03:50:53Z

That's the default, but what about -Ctarget-feature=-crt-static builds (i.e., those intended for use on Alpine or other distros where musl is the system libc).

It's rare for people to link to musl libc dynamically, and Alpine just release a new version, upgrading musl libc to 1.2.4 so I guess this is ok.

It's not like there are many other distros there using musl libc and AFAIK Alpine is mostly used for container where upgrading to new version is relatively easy.

https://www.phoronix.com/news/Alpine-Linux-3.18

nekopsykose · 2023-05-10T03:51:15Z

iirc the only actual ABI difference is the new functions in 1.2.3, like qsort_r. since musl also internally moved to qsort_r being the default qsort, i'd imagine any code that used qsort (example) would now not run on a 1.1 host indeed since the symbol won't exist in the system, when compiled with the 1.2.3 versioned rust. this would only happen if the rust compiler emitted calls to libc qsort/qsort_r(does it?), same for any other new functions(i don't remember which others).

all other libc function use comes from the libc crate, and not just this change. this only breaks running on 1.1 hosts if the compiler emits new symbols via this alone.

nekopsykose · 2023-05-10T03:52:25Z

It's rare for people to link to musl libc dynamically, and Alpine just release a new version, upgrading musl libc to 1.2.4 so I guess this is ok.

the system libc being *newer* is always fine, since there is forward compatibility. it being "rare" or not, or where dynamic musl is used or not, however, does not answer the actual question.

alex · 2023-05-10T03:56:07Z

@nekopsykose that's helpful, thanks.

(For fullness of context, my interest is that the Python ecosystem currently has a pre-built build env for binaries that target musl 1.1, but not for 1.2 yet. It seems like this may work for a little bit, until libc begins to take advantage of new symbols, and so getting a 1.2 target for Python wheels will be necessary.)

nekopsykose · 2023-05-10T04:00:13Z

until libc begins to take advantage of new symbols, and so getting a 1.2 target for Python wheels will be necessary.)

yep. currently, libc is also on 1.1.X. see rust-lang/libc#3068 for work towards 1.2 there- it will come as a new major version (0.3) when it happens.

wesleywiser · 2023-05-10T14:42:32Z

My understanding matches that of @nekopsykose's and I don't think this change by itself would cause rustc to generate calls to new symbols introduced in musl 1.2.x so dynamically linking with musl 1.1 should continue to work. That being said, @alex if it's possible for you to test in that musl 1.1 build env with Rust nightly, it would be good to confirm this.

see rust-lang/rust#107129 (comment)

alex · 2023-05-10T15:34:37Z

@wesleywiser Thanks. I can confirm (pyca/cryptography#8902) that we're able to still build and then pass our minimal smoke test on musl 1.1, using rustc nightly (dated 5/9) -- see the musllinux_1_1 builds.

wesleywiser · 2023-05-10T15:56:34Z

Thanks for testing @alex! Glad to hear it's working 🎉

…cs, r=ehuss Update platform-support.md with supported musl version This just reflects the current status quo, there is no actual change here since the update to musl 1.2.3 occurred in rust-lang#107129 and was approved in rust-lang/compiler-team#572. I also normalized all mentions of musl libc to "musl" (non-capitalized per the project's site and Wikipedia page). r? `@ehuss`

…cs, r=ehuss Update platform-support.md with supported musl version This just reflects the current status quo, there is no actual change here since the update to musl 1.2.3 occurred in rust-lang#107129 and was approved in rust-lang/compiler-team#572. I also normalized all mentions of musl libc to "musl" (non-capitalized per the project's site and Wikipedia page). r? ``@ehuss``

Rollup merge of rust-lang#121994 - wesleywiser:update_musl_version_docs, r=ehuss Update platform-support.md with supported musl version This just reflects the current status quo, there is no actual change here since the update to musl 1.2.3 occurred in rust-lang#107129 and was approved in rust-lang/compiler-team#572. I also normalized all mentions of musl libc to "musl" (non-capitalized per the project's site and Wikipedia page). r? ``@ehuss``

Update the version of musl used on `*-linux-musl` targets to 1.2.3 Update the version of musl used on our Linux musl targets from 1.1.24 to 1.2.3 as proposed in rust-lang/compiler-team#572. musl 1.2.3 is the latest version of musl and supports the same range of Linux kernels as the 1.1 series. As such, it does not affect the minimum supported version of Linux for any of the musl targets. One of the major musl 1.2 features is support for [time64](https://musl.libc.org/time64.html). This support is both source and ABI compatible with programs built against musl 1.1 and so updating the musl version for these targets should not cause Rust programs to fail to run or compile (a [crater run](rust-lang/rust#107129 (comment)) has been completed which demonstrates this for the `i686-unknown-linux-musl` target). Once this change reaches stable, the `libc` crate will then be able to [update their definitions to support 64-bit time](rust-lang/libc#3068), matching the default musl 1.2 APIs exactly. Fixes #91178

Update bundled musl to 1.2.5 [Releases page](https://musl.libc.org/releases.html) Prior update: rust-lang#107129 r? `@wesleywiser` try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl

Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. [Releases page](https://musl.libc.org/releases.html) Prior update: rust-lang#107129 `r? wesleywiser` try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl

Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. [Releases page](https://musl.libc.org/releases.html) Prior update: rust-lang#107129 `r? wesleywiser` try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux

wesleywiser added 3 commits January 20, 2023 15:20

Upgrade to musl 1.2.3

4af36a4

Bump musl-cross-make to get support for building musl 1.2.3

7a4eefc

Specify version of Linux headers

cb93f92

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 20, 2023

This comment was marked as resolved.

Sign in to view

wesleywiser force-pushed the musl_1.2_upgrade branch from 97795b0 to cb93f92 Compare January 21, 2023 02:34

This comment was marked as resolved.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2023

This comment was marked as resolved.

Sign in to view

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 24, 2023

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2023

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 27, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label May 8, 2023

alex added a commit to pyca/cryptography that referenced this pull request May 10, 2023

test wheel-builder with nightly

e5732d7

see rust-lang/rust#107129 (comment)

alex mentioned this pull request May 10, 2023

test wheel-builder with nightly pyca/cryptography#8902

Closed

lu-zero mentioned this pull request May 19, 2023

Rust failed to build openwrt/packages#21095

Closed

apiraino removed the to-announce Announce this issue on triage meeting label May 25, 2023

wesleywiser mentioned this pull request Jul 7, 2023

Add blog post for 1.71 rust-lang/blog.rust-lang.org#1118

Merged

JohnTitor mentioned this pull request Nov 3, 2023

Upgrade musl supported version to 1.2.3 rust-lang/libc#3068

Open

wesleywiser mentioned this pull request Mar 4, 2024

Update platform-support.md with supported musl version #121994

Merged

est31 mentioned this pull request May 29, 2024

Update bundled musl to 1.2.5 #125692

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the version of musl used on `*-linux-musl` targets to 1.2.3 #107129

Update the version of musl used on `*-linux-musl` targets to 1.2.3 #107129

wesleywiser commented Jan 20, 2023 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

wesleywiser commented Jan 20, 2023

bors commented Jan 20, 2023

bors commented Jan 21, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

wesleywiser commented Jan 26, 2023

craterbot commented Jan 26, 2023

craterbot commented Jan 26, 2023

craterbot commented Jan 27, 2023

wesleywiser commented Jan 27, 2023

lqd commented May 8, 2023

alex commented May 9, 2023

NobodyXu commented May 10, 2023

alex commented May 10, 2023

NobodyXu commented May 10, 2023

nekopsykose commented May 10, 2023

nekopsykose commented May 10, 2023

alex commented May 10, 2023

nekopsykose commented May 10, 2023

wesleywiser commented May 10, 2023

alex commented May 10, 2023

wesleywiser commented May 10, 2023

Update the version of musl used on *-linux-musl targets to 1.2.3 #107129

Update the version of musl used on *-linux-musl targets to 1.2.3 #107129

Conversation

wesleywiser commented Jan 20, 2023 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

wesleywiser commented Jan 20, 2023

bors commented Jan 20, 2023

bors commented Jan 21, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

wesleywiser commented Jan 26, 2023

craterbot commented Jan 26, 2023

craterbot commented Jan 26, 2023

craterbot commented Jan 27, 2023

wesleywiser commented Jan 27, 2023

lqd commented May 8, 2023

alex commented May 9, 2023

NobodyXu commented May 10, 2023

alex commented May 10, 2023

NobodyXu commented May 10, 2023

nekopsykose commented May 10, 2023

nekopsykose commented May 10, 2023

alex commented May 10, 2023

nekopsykose commented May 10, 2023

wesleywiser commented May 10, 2023

alex commented May 10, 2023

wesleywiser commented May 10, 2023

Update the version of musl used on `*-linux-musl` targets to 1.2.3 #107129

Update the version of musl used on `*-linux-musl` targets to 1.2.3 #107129

wesleywiser commented Jan 20, 2023 •

edited

Loading