-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #107020
Rollup of 7 pull requests #107020
Commits on Dec 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8915ba7 - Browse repository at this point
Copy the full SHA 8915ba7View commit details
Commits on Jan 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 273c6c3 - Browse repository at this point
Copy the full SHA 273c6c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54089e6 - Browse repository at this point
Copy the full SHA 54089e6View commit details -
add debug assertion for suggestions with overlapping parts
Lukas Markeffsky committedJan 17, 2023 Configuration menu - View commit details
-
Copy full SHA for e551456 - Browse repository at this point
Copy the full SHA e551456View commit details -
preserve delim spans during
macro_rules!
expansion if ableLukas Markeffsky committedJan 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 12c0d39 - Browse repository at this point
Copy the full SHA 12c0d39View commit details -
fix overlapping spans for
explicit_outlives_requirements
in macrosalso delete trailing comma if necessary
Lukas Markeffsky committedJan 17, 2023 Configuration menu - View commit details
-
Copy full SHA for d18768a - Browse repository at this point
Copy the full SHA d18768aView commit details -
bump failing assembly & codegen tests from LLVM 14 to LLVM 15
Lukas Markeffsky committedJan 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 1216cc7 - Browse repository at this point
Copy the full SHA 1216cc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a242a2c - Browse repository at this point
Copy the full SHA a242a2cView commit details -
Add 'static lifetime suggestion when GAT implied 'static requirement …
…from HRTB
yanchen4791 committedJan 17, 2023 Configuration menu - View commit details
-
Copy full SHA for aadd58e - Browse repository at this point
Copy the full SHA aadd58eView commit details
Commits on Jan 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4ca5368 - Browse repository at this point
Copy the full SHA 4ca5368View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88f81a0 - Browse repository at this point
Copy the full SHA 88f81a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2a50f9 - Browse repository at this point
Copy the full SHA a2a50f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1171fe5 - Browse repository at this point
Copy the full SHA 1171fe5View commit details -
Rollup merge of rust-lang#106244 - atouchet:readme3, r=workingjubilee
Improve Markdown styling in README Update Readme to use consistent line lengths. Also update some formatting and links. (Followup to rust-lang#105553). r? `@workingjubilee`
Configuration menu - View commit details
-
Copy full SHA for cd60c4d - Browse repository at this point
Copy the full SHA cd60c4dView commit details -
Rollup merge of rust-lang#106747 - yanchen4791:issue-105507-fix, r=es…
…tebank Add 'static lifetime suggestion when GAT implied 'static requirement from HRTB Fix for issue rust-lang#105507 The problem: When generic associated types (GATs) are from higher-ranked trait bounds (HRTB), they are implied 'static requirement (see [Implied 'static requirement from higher-ranked trait bounds](https://blog.rust-lang.org/2022/10/28/gats-stabilization.html#implied-static-requirement-from-higher-ranked-trait-bounds) for more details). If the user did not explicitly specify the `'static` lifetime when using the GAT, the current error message will only point out the type `does not live long enough` where the type is used, but not where the GAT is specified and how to fix the problem. The solution: Add notes at the span where the problematic GATs are specified and suggestions of how to fix the problem by adding `'static` lifetime at the right spans.
Configuration menu - View commit details
-
Copy full SHA for 9696b23 - Browse repository at this point
Copy the full SHA 9696b23View commit details -
Rollup merge of rust-lang#106873 - BoxyUwU:ty_const_formatting, r=com…
…piler-errors dont randomly use `_` to print out const generic arguments const generics seem to get printed out as `_` for no reason a lot of the time, as someone who spends a lot of time with const generics this has gotten ✨ very annoying ✨. Latest example would be rust-lang#106423 where the ICE messaged formatted a `ty::Const` containing no infer vars, as `_`. For some reason printing of the const argument on arrays was custom instead of using the existing logic for printing `ty::Const`. Additionally the existing logic for printing `ty::Const` would print out `_` for anon consts that are in a separate crate leading to weird diagnostics (see second commit). There ought to be less cases of consts randomly getting printed as `_` hiding valuable info now.
Configuration menu - View commit details
-
Copy full SHA for a7daf9a - Browse repository at this point
Copy the full SHA a7daf9aView commit details -
Rollup merge of rust-lang#106916 - lukas-code:overlapping-substs, r=e…
…stebank Remove overlapping parts of multipart suggestions This PR adds a debug assertion that the parts of a single substitution cannot overlap, fixes a overlapping substitution from the testsuite, and fixes rust-lang#106870. Note that a single suggestion can still have multiple overlapping substitutions / possible edits, we just don't suggest overlapping replacements in a single edit anymore. I've also included a fix for an unrelated bug where rustfix for `explicit_outlives_requirements` would produce multiple trailing commas for a where clause.
Configuration menu - View commit details
-
Copy full SHA for 9598369 - Browse repository at this point
Copy the full SHA 9598369View commit details -
Rollup merge of rust-lang#106995 - lukas-code:align_offset_assembly_t…
…est, r=cuviper bump failing assembly & codegen tests from LLVM 14 to LLVM 15 These tests need LLVM 15. Found by ``@Robert-Cunningham`` in rust-lang#100601 (comment) Passed tests at 006506e93fc80318ebfd7939fe1fd4dc19ecd8cb in https://github.com/rust-lang/rust/actions/runs/3942442730/jobs/6746104740.
Configuration menu - View commit details
-
Copy full SHA for b50c6b7 - Browse repository at this point
Copy the full SHA b50c6b7View commit details -
Rollup merge of rust-lang#106996 - notriddle:notriddle/settings-line-…
…div, r=GuillaumeGomez rustdoc: instead of `.setting-name { width: 100% }`, use default div CSS This has no discernible change in appearance.
Configuration menu - View commit details
-
Copy full SHA for dc9db57 - Browse repository at this point
Copy the full SHA dc9db57View commit details -
Rollup merge of rust-lang#106997 - Sp00ph:introselect, r=scottmcm
Add heapsort fallback in `select_nth_unstable` Addresses rust-lang#102451 and rust-lang#106933. `slice::select_nth_unstable` uses a quick select implementation based on the same pattern defeating quicksort algorithm that `slice::sort_unstable` uses. `slice::sort_unstable` uses a recursion limit and falls back to heapsort if there were too many bad pivot choices, to ensure O(n log n) worst case running time (known as introsort). However, `slice::select_nth_unstable` does not have such a fallback strategy, which leads to it having a worst case running time of O(n²) instead. rust-lang#102451 links to a playground which generates pathological inputs that show this quadratic behavior. On my machine, a randomly generated slice of length `1 << 19` takes ~200µs to calculate its median, whereas a pathological input of the same length takes over 2.5s. This PR adds an iteration limit to `select_nth_unstable`, falling back to heapsort, which ensures an O(n log n) worst case running time (introselect). With this change, there was no noticable slowdown for the random input, but the same pathological input now takes only ~1.2ms. In the future it might be worth implementing something like Median of Medians or Fast Deterministic Selection instead, which guarantee O(n) running time for all possible inputs. I've left this as a `FIXME` for now and only implemented the heapsort fallback to minimize the needed code changes. I still think we should clarify in the `select_nth_unstable` docs that the worst case running time isn't currently O(n) (the original reason that rust-lang#102451 was opened), but I think it's a lot better to be able to guarantee O(n log n) instead of O(n²) for the worst case.
Configuration menu - View commit details
-
Copy full SHA for 545ec30 - Browse repository at this point
Copy the full SHA 545ec30View commit details