Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove docblock class from notable trait popover #106828

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

notriddle
Copy link
Contributor

This commit builds on b72de9b, which removes the docblock class from the All Items page, and 9457380, which removes the docblock class from the item decl.

Fixes #92974

This commit builds on b72de9b, which removes
the `docblock` class from the All Items page, and
9457380, which removes the `docblock` class
from the item decl.

Fixes rust-lang#92974
@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 13, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 14, 2023

📌 Commit 5314ed5 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105526 (libcore: make result of iter::from_generator Clone)
 - rust-lang#106563 (Fix `unused_braces` on generic const expr macro call)
 - rust-lang#106661 (Stop probing for statx unless necessary)
 - rust-lang#106820 (Deprioritize fulfillment errors that come from expansions.)
 - rust-lang#106828 (rustdoc: remove `docblock` class from notable trait popover)
 - rust-lang#106849 (Allocate one less vec while parsing arrays)
 - rust-lang#106855 (rustdoc: few small cleanups)
 - rust-lang#106860 (Remove various double spaces in the libraries.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 14fbc21 into rust-lang:master Jan 15, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 15, 2023
@notriddle notriddle deleted the notriddle/notable-trait-docblock branch January 15, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: use docblock class more precisely
4 participants