-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix comment for TokenCursor::desugar
#106268
Conversation
the hashes of the text were forgotten.
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
r? Nilstrieb |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e5e5fcb): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
That's some interesting perf numbers. Just noise/bimodality but very weird that even a comment change would trigger this. cc @rust-lang/wg-compiler-performance |
fix comment for `TokenCursor::desugar` the hashes of the text were forgotten.
the hashes of the text were forgotten.