Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused flex-grow CSS rule #105823

Closed
wants to merge 1 commit into from
Closed

Remove unused flex-grow CSS rule #105823

wants to merge 1 commit into from

Conversation

GuillaumeGomez
Copy link
Member

It's not a flex item so the rule has no effect on it.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 17, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 17, 2022

📌 Commit daa7283 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2022
@notriddle
Copy link
Contributor

@bors r-

How is it not a flex item? These are direct children of example-wrap, which is display: flex right here.

https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/css/rustdoc.css#L530

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2022
@GuillaumeGomez
Copy link
Member Author

It's this rule that is applied: https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/css/rustdoc.css#L1979. So not flex items.

@GuillaumeGomez
Copy link
Member Author

How I discovered it:

image

@notriddle
Copy link
Contributor

notriddle commented Dec 17, 2022 •
edited
Loading

Yeah, scraped examples are special. They use CSS grid for this while everything else uses flexbox.

https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/css/rustdoc.css#L1979

83ba425

It would probably be a good idea to make a more elaborate PR to have example-wrap always use grid,

@GuillaumeGomez
Copy link
Member Author

I see. Closing in the meantime then.

@GuillaumeGomez GuillaumeGomez deleted the unused-flex-grow-css-rule branch December 18, 2022 16:36
This was referenced Dec 19, 2022
Closed
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#105914 - GuillaumeGomez:simplify-css-exampl…
1abbc3f 
…es-code-blocks, r=notriddle

rustdoc: Simplify CSS for scraped code examples code blocks

It's another approach than rust-lang#105894 for rust-lang#105823.

I simply removed the extra style added for the scraped code blocks which appears to be unneeded.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rustbot @Dylan-DPC @bors @notriddle