Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module instruction stats #104178

Closed
wants to merge 3 commits into from
Closed

Add module instruction stats #104178

wants to merge 3 commits into from

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented Nov 9, 2022

r? @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2022
@bjorn3
Copy link
Member

bjorn3 commented Nov 9, 2022

Makes sense to add this. Shouldn't be an unconditional println!() though. Maybe an info!()?

@csmoe
Copy link
Member Author

csmoe commented Nov 9, 2022

yep, I was println to test locally, and trying to figure out how to add this data to perf metrics as this roadmap listed(#89281).

@bjorn3 bjorn3 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2023
@csmoe csmoe closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjorn3 bjorn3

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csmoe @bjorn3 @rustbot