Rollup of 6 pull requests

[Dylan-DPC]

Successful merges:

• Correctly resolve Inherent Associated Types #103621 (Correctly resolve Inherent Associated Types)
• improve filesearch::get_or_default_sysroot #103660 (improve filesearch::get_or_default_sysroot)
• Remove some return-type diagnostic booleans from FnCtxt #103866 (Remove some return-type diagnostic booleans from FnCtxt)
• Remove has_errors from FnCtxt #103867 (Remove has_errors from FnCtxt)
• Specify that break cannot be used outside of loop *or* labeled block #103994 (Specify that break cannot be used outside of loop or labeled block)
• Small round of typo fixes #103995 (Small round of typo fixes)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[Dylan-DPC]

@bors r+ rollup=never p=5

[bors]

📌 Commit 47e6304 has been approved by Dylan-DPC

It is now in the queue for this repository.

[bors]

⌛ Testing commit 47e6304 with merge 452cf4f...

[bors]

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 452cf4f to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#103995	ab49a46e4319908488e338b5d3ccec4e09789240
#103994	72c0211942515ad14c4f4b73186b7ff62e1fb124
#103867	5a08a03db5fb312f1268fba62a175d1459a3b133
#103866	dc2a9d74eef01b9b5d25e1d81055fef7c0cc485f
#103660	1fea4e8e78a93deae77f8d0bd3a9c8a326f538d9
#103621	b236bd5c0f5c99cc3a584fb1ea2d19ab39d9bb50

previous master: 5b3e909075

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (452cf4f): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[0.3%, 3.9%]	6
Regressions ❌ (secondary)	1.4%	[0.4%, 3.5%]	43
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-1.5%, -1.0%]	2
All ❌✅ (primary)	2.5%	[0.3%, 3.9%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.6%, 2.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-3.1%	[-5.4%, -1.2%]	3
All ❌✅ (primary)	0.9%	[-0.5%, 2.7%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[0.7%, 4.9%]	3
Regressions ❌ (secondary)	2.6%	[2.1%, 4.0%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	3.1%	[0.7%, 4.9%]	3

[Mark-Simulacrum]

@rust-timer build 1fea4e8e78a93deae77f8d0bd3a9c8a326f538d9

@rust-timer build b236bd5c0f5c99cc3a584fb1ea2d19ab39d9bb50

[rust-timer]

Finished benchmarking commit (1fea4e8e78a93deae77f8d0bd3a9c8a326f538d9): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[0.3%, 4.4%]	6
Regressions ❌ (secondary)	1.6%	[0.4%, 3.9%]	45
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	2.9%	[0.3%, 4.4%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.8%, 2.8%]	2
Regressions ❌ (secondary)	8.8%	[8.8%, 8.8%]	1
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-4.3%	[-5.5%, -2.2%]	4
All ❌✅ (primary)	1.0%	[-0.5%, 2.8%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.6%	[4.0%, 5.2%]	3
Regressions ❌ (secondary)	2.9%	[1.9%, 4.1%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.6%, -2.3%]	3
All ❌✅ (primary)	4.6%	[4.0%, 5.2%]	3