rustpkg: Un-ignore test_install_invalid_external and test_install_invalid #10369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this will fix #9994 |
|
Re-r? @alexcrichton or @cmr or @brson or @metajack |
| @@ -41,10 +42,74 @@ impl Eq for PkgId { | |||
| } | |||
| } | |||
|
|
|||
| // n.b. This code is pretty silly; we should use the real URL library. | |||
There was a problem hiding this comment.
We do have extra::url, I don't know much about it, but was that insufficient?
There was a problem hiding this comment.
@alexcrichton It wasn't insufficient, I just thought it was faster to write the simple version from scratch than to look at the url library. If you'd rather I implement it properly before landing it, I can :-)
There was a problem hiding this comment.
Let's at least look into it, although if it looks odd, feel free to open an issue on it.
Re-enable test_install_invalid_external and test_install_invalid Also improves an error message Closes rust-lang#9994
|
Closing due to inactivity, but feel free to reopen if you have updates! |
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Feb 26, 2023
Add new lint no_mangle_with_rust_abi Fixes issue rust-lang#10347 This PR adds a new lint `no_mangle_with_rust_abi` that suggests converting a function to the C ABI to if the function has the `#[no_mangle]` attribute and `Abi == Abi::Rust`. It will not run for any of the other variants defined in [rustc_target::spec::abi::Abi](https://doc.rust-lang.org/beta/nightly-rustc/rustc_target/spec/abi/enum.Abi.html), nor suggest any conversion other than conversion to the C ABI. Functions that explicitly opt into the Rust ABI with `extern "Rust"` are ignored by this lint. --- changelog: [`no_mangle_with_rust_abi`]: add lint that converts Rust ABI functions with the `#[no_mangle]` attribute to C ABI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson or @cmr or @metajack or anyone else who is around