Rollup of 6 pull requests #103431
Merged
Rollup of 6 pull requests #103431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, r=estebank Recover when unclosed char literal is parsed as a lifetime in some positions Fixes rust-lang#101278
Suggest let for assignment, and some code refactor Fixes rust-lang#101880
rustdoc: Eliminate uses of `EarlyDocLinkResolver::all_traits` Another step to rust-lang#94857.
…r, r=lcnr Check `needs_infer` before `needs_drop` during HIR generator analysis This is kinda a revival of rust-lang#103036, but with the understanding that after fallback, a generator-interior type will only have `needs_infer` true if there's an error that prevented int or float variable fallback to occur (modulo region variables, which are erased). Therefore the best choice here is to delay a bug and skip the `needs_drop` call altogether. r? `@lcnr` feel free to reassign though
resolve: Revert "Set effective visibilities for imports more precisely" In theory the change was correct, but in practice the use of import items in HIR is limited and hacky, and it expects that (effective) visibilities for all (up to) 3 IDs of the import are set to the value reflecting (effective) visibility of the whole syntactic `use` item rather than its individual components. Fixes rust-lang#102352 r? `@oli-obk`
Move some tests to more reasonable places r? `@petrochenkov`
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=5 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: e64f1110c0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Oct 23, 2022
|
Finished benchmarking commit (9be2f35): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
EarlyDocLinkResolver::all_traits#103192 (rustdoc: Eliminate uses ofEarlyDocLinkResolver::all_traits)needs_inferbeforeneeds_dropduring HIR generator analysis #103226 (Checkneeds_inferbeforeneeds_dropduring HIR generator analysis)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup