Fix #1015 #1030
Merged
Fix #1015 #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
The section was removed in rust-lang#1030 and re-added in a different place in 2d42cf7.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
The section was removed in rust-lang#1030 and re-added in a different place in 2d42cf7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #1015. I have reimplemented
str_to_floatto extend the grammar that it can parse. Including, say, strings with a decimal part :)I take the opportunity to replace the implementation of
int::powto use fast exponentiation, to add a few functions to the newfloatmodule, as well as a few tests. I also renamedstr_to_floatandfloat_to_strintofloat::from_strandfloat::to_str, to harmonize with theintmodule.