Rollup of 7 pull requests #102975

Dylan-DPC · 2022-10-12T16:43:27Z

Successful merges:

translation: eager translation #102623 (translation: eager translation)
Enforce alphabetical sorting with tidy #102719 (Enforce alphabetical sorting with tidy)
Unify tcx.constness query and param env constness checks #102830 (Unify tcx.constness query and param env constness checks)
Fix stabilization of feature(half_open_range_patterns) #102883 (Fix stabilization of feature(half_open_range_patterns))
Fix let keyword removal suggestion in structs #102927 (Fix let keyword removal suggestion in structs)
rustdoc: remove unused CSS nav.sum #102936 (rustdoc: remove unused CSS nav.sum)
Update books #102940 (Update books)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Small tweaks to changes made in a previous PR, unrelated to eager translation. Signed-off-by: David Wood <[email protected]>

Eager translation will enable subdiagnostics to be translated multiple times with different arguments - this requires the ability to replace the value of one argument with a new value, which is better suited to a `HashMap` than the previous storage, a `Vec`. Signed-off-by: David Wood <[email protected]>

`AddToDiagnostic::add_to_diagnostic_with` is similar to the previous `AddToDiagnostic::add_to_diagnostic` but takes a function that can be used by the caller to modify diagnostic messages originating from the subdiagnostic (such as performing translation eagerly). `add_to_diagnostic` now just calls `add_to_diagnostic_with` with an empty closure. Signed-off-by: David Wood <[email protected]>

Add variant of `DiagnosticMessage` for eagerly translated messages (messages in the target language which don't need translated by the emitter during emission). Also adds `eager_subdiagnostic` function which is intended to be invoked by the diagnostic derive for subdiagnostic fields which are marked as needing eager translation. Signed-off-by: David Wood <[email protected]>

Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <[email protected]>

Using eager translation, migrate the remaining repeated cycle stack diagnostic. Signed-off-by: David Wood <[email protected]>

Diagnostic derives have previously had to take special care when ordering the generated code so that fields were not used after a move. This is unlikely for most fields because a field is either annotated with a subdiagnostic attribute and is thus likely a `Span` and copiable, or is a argument, in which case it is only used once by `set_arg` anyway. However, format strings for code in suggestions can result in fields being used after being moved if not ordered carefully. As a result, the derive currently puts `set_arg` calls last (just before emission), such as: ```rust let diag = { /* create diagnostic */ }; diag.span_suggestion_with_style( span, fluent::crate::slug, format!("{}", __binding_0), Applicability::Unknown, SuggestionStyle::ShowAlways ); /* + other subdiagnostic additions */ diag.set_arg("foo", __binding_0); /* + other `set_arg` calls */ diag.emit(); ``` For eager translation, this doesn't work, as the message being translated eagerly can assume that all arguments are available - so arguments _must_ be set first. Format strings for suggestion code are now separated into two parts - an initialization line that performs the formatting into a variable, and a usage in the subdiagnostic addition. By separating these parts, the initialization can happen before arguments are set, preserving the desired order so that code compiles, while still enabling arguments to be set before subdiagnostics are added. ```rust let diag = { /* create diagnostic */ }; let __code_0 = format!("{}", __binding_0); /* + other formatting */ diag.set_arg("foo", __binding_0); /* + other `set_arg` calls */ diag.span_suggestion_with_style( span, fluent::crate::slug, __code_0, Applicability::Unknown, SuggestionStyle::ShowAlways ); /* + other subdiagnostic additions */ diag.emit(); ``` Signed-off-by: David Wood <[email protected]>

Following the approach taken in earlier commits to separate formatting initialization from use in the subdiagnostic derive, simplify the diagnostic derive by removing the field-ordering logic that previously solved this problem. Signed-off-by: David Wood <[email protected]>

This was added in 4fd061c, but never actually used.

It can be used to ensure that a list of things is sorted alphabetically. It goes off lines, but contains several heuristics to work with normal Rust code (looking at indentation, ignoring comments and attributes).

…piler-errors translation: eager translation Part of rust-lang#100717. See [Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/336883-i18n/topic/.23100717.20lists!/near/295010720) for additional context. - **Store diagnostic arguments in a `HashMap`**: Eager translation will enable subdiagnostics to be translated multiple times with different arguments - this requires the ability to replace the value of one argument with a new value, which is better suited to a `HashMap` than the previous storage, a `Vec`. - **Add `AddToDiagnostic::add_to_diagnostic_with`**: `AddToDiagnostic::add_to_diagnostic_with` is similar to the previous `AddToDiagnostic::add_to_diagnostic` but takes a function that can be used by the caller to modify diagnostic messages originating from the subdiagnostic (such as performing translation eagerly). `add_to_diagnostic` now just calls `add_to_diagnostic_with` with an empty closure. - **Add `DiagnosticMessage::Eager`**: Add variant of `DiagnosticMessage` for eagerly translated messages (messages in the target language which don't need translated by the emitter during emission). Also adds `eager_subdiagnostic` function which is intended to be invoked by the diagnostic derive for subdiagnostic fields which are marked as needing eager translation. - **Support `#[subdiagnostic(eager)]`**: Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. - **Finish migrating `rustc_query_system`**: Using eager translation, migrate the remaining repeated cycle stack diagnostic. - **Split formatting initialization and use in diagnostic derives**: Diagnostic derives have previously had to take special care when ordering the generated code so that fields were not used after a move. This is unlikely for most fields because a field is either annotated with a subdiagnostic attribute and is thus likely a `Span` and copiable, or is a argument, in which case it is only used once by `set_arg` anyway. However, format strings for code in suggestions can result in fields being used after being moved if not ordered carefully. As a result, the derive currently puts `set_arg` calls last (just before emission), such as: let diag = { /* create diagnostic */ }; diag.span_suggestion_with_style( span, fluent::crate::slug, format!("{}", __binding_0), Applicability::Unknown, SuggestionStyle::ShowAlways ); /* + other subdiagnostic additions */ diag.set_arg("foo", __binding_0); /* + other `set_arg` calls */ diag.emit(); For eager translation, this doesn't work, as the message being translated eagerly can assume that all arguments are available - so arguments _must_ be set first. Format strings for suggestion code are now separated into two parts - an initialization line that performs the formatting into a variable, and a usage in the subdiagnostic addition. By separating these parts, the initialization can happen before arguments are set, preserving the desired order so that code compiles, while still enabling arguments to be set before subdiagnostics are added. let diag = { /* create diagnostic */ }; let __code_0 = format!("{}", __binding_0); /* + other formatting */ diag.set_arg("foo", __binding_0); /* + other `set_arg` calls */ diag.span_suggestion_with_style( span, fluent::crate::slug, __code_0, Applicability::Unknown, SuggestionStyle::ShowAlways ); /* + other subdiagnostic additions */ diag.emit(); - **Remove field ordering logic in diagnostic derive:** Following the approach taken in earlier commits to separate formatting initialization from use in the subdiagnostic derive, simplify the diagnostic derive by removing the field-ordering logic that previously solved this problem. r? ```@compiler-errors```

…kh726 Enforce alphabetical sorting with tidy We have many places where things are supposed to be sorted alphabetically. For the smaller and more recent size assertions, this is mostly upheld, but in other more... alive places it's very messy. This introduces a new tidy directive to check that a section of code is sorted alphabetically and fixes all places where sorting has gone wrong.

…r=fee1-dead Unify `tcx.constness` query and param env constness checks The checks that we do in the `constness` query seem inconsistent with the checks that we do to determine if an item's param-env is const, so I merged them into the `constness` query and call that from the `param_env` query. I'm not sure if this totally makes sense -- is there a case where `tcx.param_env()` would return a const param-env for an item whose `tcx.constness()` is `Constness::NotConst`? Because if not, it seems a bit dangerous that these two differ. Luckily, not many places actually use `tcx.constness()`, and the checks in `tcx.param_env()` seem stricter than the checks in `tcx.constness()` (at least for the types of items we type-check). Also, due to the way that `tcx.param_env()` is implemented, it _never_ used to return a const param-env for a item coming from a different crate, which also seems dangerous (though also probably not weaponizable currently, because we seldom actually compute the param-env for a non-local item).

…range_patterns, r=lcnr Fix stabilization of `feature(half_open_range_patterns)` Fixes https://github.com/rust-lang/rust/pull/102275/files#r991292215 by removing the relevant code that was [already partial moved](https://github.com/rust-lang/rust/pull/102275/files#diff-307e0d3a2037c11a3fa16822fbaa0fec08e57ac7d0d6e7354f6005c9482a9e26). cc `@Undin`

Fix `let` keyword removal suggestion in structs (1.) Fixes a bug where, given this code: ```rust struct Foo { let x: i32, } ``` We were parsing the field name as `let` instead of `x`, which causes issues later on in the type-checking phase. (2.) Also, suggestions for `let: i32` as a field regressed, displaying this extra `help:` which is removed by this PR ``` help: remove the let, the `let` keyword is not allowed in struct field definitions | 2 - let: i32, 2 + : i32, ``` (3.) Makes the suggestion text a bit more succinct, since we don't need to re-explain that `let` is not allowed in this position (since it's in a note that follows). This causes the suggestion to render inline as well. cc `@gimbles,` this addresses a few nits I mentioned in your PR.

…an-DPC rustdoc: remove unused CSS `nav.sum` This was added in 4fd061c, but never actually used.

Update books ## nomicon 1 commits in f53bfa056929217870a5d2df1366d2e7ba35096d..9c73283775466d22208a0b28afcab44db4c0cc10 2022-09-05 07:19:02 -0700 to 2022-09-30 07:31:22 +0900 - Fix typo (rust-lang/nomicon#380) ## reference 9 commits in a7cdac33ca7356ad49d5c2b5e2c5010889b33eee..f6ed74f582bddcec73f753eafaab3749c4f7df61 2022-09-19 17:39:58 -0700 to 2022-10-08 02:43:26 -0700 - Typo 'a' -> 'an' (rust-lang/reference#1280) - One line one sentence for expressions and statements main chapters (rust-lang/reference#1277) - Document let else statements (rust-lang/reference#1156) - Document `label_break_value` in the reference (rust-lang/reference#1263) - Document target_has_atomic (rust-lang/reference#1171) - update 'unsafe' (rust-lang/reference#1278) - Update tokens.md (rust-lang/reference#1276) - One sentence, one line Patterns chapter (rust-lang/reference#1275) - Use semver-compliant example version (rust-lang/reference#1272) ## rust-by-example 9 commits in 767a6bd9727a596d7cfdbaeee475e65b2670ea3a..5e7b296d6c345addbd748f242aae28c42555c015 2022-09-14 09:17:18 -0300 to 2022-10-05 08:24:45 -0300 - Make it clear that rustdoc uses the commonmark spec (rust-lang/rust-by-example#1622) - Update defaults.md (rust-lang/rust-by-example#1615) - added "see also" for the @ binding sigil (rust-lang/rust-by-example#1612) - add more precision to the effects of --bin flag (rust-lang/rust-by-example#1607) - create bar project in cargo/dependencies example (rust-lang/rust-by-example#1606) - use consistent wording about type annotation (rust-lang/rust-by-example#1603) - cast.md improvements (rust-lang/rust-by-example#1599) - Fix typo in macros.md (rust-lang/rust-by-example#1598) - Corrected mistaken "The" instead of "There" (rust-lang/rust-by-example#1617) ## rustc-dev-guide 2 commits in 9a86c0467bbe42056f73fdf5b03fff757d7c4a9b..7518c3445dc02df0d196f5f84e568d633c5141fb 2022-10-07 18:34:51 +0200 to 2022-10-08 12:29:47 +0200 - Update debugging.md - Use llvm subdomain for compiler-explorer link ## embedded-book 1 commits in 4ce51cb7441a6f02b5bf9b07b2eb755c21ab7954..c533348edd69f11a8f4225d633a05d7093fddbf3 2022-09-15 08:53:09 +0000 to 2022-10-10 10:16:49 +0000 - Fix a typo in registers.md (rust-embedded/book#330)

Dylan-DPC · 2022-10-12T16:43:45Z

@bors r+ rollup=never p=5

bors · 2022-10-12T16:43:47Z

📌 Commit f2c4810 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-10-12T17:48:35Z

⌛ Testing commit f2c4810 with merge c0983a9...

bors · 2022-10-12T20:53:28Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing c0983a9 to master...

rust-timer · 2022-10-12T20:55:48Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#102940	1a9f9d055dde0efde36c508d69bbaa2a50d94f49
#102936	a9f730fae0d5a8f8586ef57ac4a0d46f611e80b2
#102927	4ccaf7d74596fa36d96485ba161329a782d53ca6
#102883	4b498f4a13f9df1bd7820171963ae9be7db3f084
#102830	904567d19629d4e9cbc169d77444bf469ed46343
#102719	3410da5652d14954482567875dab7b1be633ba0c
#102623	9313c04664029a6ac2cdca57c4c86f320900b2eb

previous master: 538f118da1

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-10-12T23:26:51Z

Finished benchmarking commit (c0983a9): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.6%	[0.2%, 1.0%]	19
Regressions ❌ (secondary)	1.3%	[0.2%, 3.8%]	41
Improvements ✅ (primary)	-0.9%	[-1.7%, -0.4%]	14
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-1.7%, 1.0%]	33

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.6%	[0.6%, 3.5%]	3
Regressions ❌ (secondary)	2.2%	[2.0%, 2.3%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.6%, -1.6%]	1
All ❌✅ (primary)	1.6%	[0.6%, 3.5%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	2.7%	[2.6%, 3.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

Mark-Simulacrum · 2022-10-18T12:59:40Z

@rust-timer build 904567d19629d4e9cbc169d77444bf469ed46343

rust-timer · 2022-10-18T12:59:42Z

Queued 904567d19629d4e9cbc169d77444bf469ed46343 with parent 538f118, future comparison URL.

rust-timer · 2022-10-18T16:53:23Z

Finished benchmarking commit (904567d19629d4e9cbc169d77444bf469ed46343): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.5%	[0.2%, 1.0%]	27
Regressions ❌ (secondary)	1.0%	[0.2%, 2.7%]	33
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.2%, 1.0%]	27

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	3.6%	[0.4%, 7.6%]	8
Regressions ❌ (secondary)	2.3%	[2.2%, 2.6%]	6
Improvements ✅ (primary)	-8.8%	[-17.4%, -2.1%]	23
Improvements ✅ (secondary)	-3.3%	[-4.4%, -1.6%]	4
All ❌✅ (primary)	-5.6%	[-17.4%, 7.6%]	31

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.2%	[1.1%, 3.1%]	29
Regressions ❌ (secondary)	3.0%	[2.0%, 4.8%]	38
Improvements ✅ (primary)	-14.4%	[-29.1%, -1.6%]	45
Improvements ✅ (secondary)	-8.5%	[-12.8%, -2.6%]	14
All ❌✅ (primary)	-7.9%	[-29.1%, 3.1%]	74

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

rylev · 2022-10-19T08:33:32Z

@compiler-errors @fee1-dead it seems that #102830 has produced perf regressions.

I ran callgrind-diff on bitmaps check incremental unchanged and got the following which definitely seems related to the change in the suspect PR:

3,833,992  ???:rustc_query_system::query::plumbing::get_query::<rustc_query_impl::queries::constness, rustc_query_impl::plumbing::QueryCtxt>
2,908,408  ???:<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
1,174,324  ???:<rustc_query_system::dep_graph::serialized::SerializedDepGraph<rustc_middle::dep_graph::dep_node::DepKind> as rustc_serialize::serialize::Decodable<rustc_serialize::opaque::MemDecoder>>::decode
  863,312  ???:rustc_query_system::dep_graph::graph::hash_result::<rustc_hir::hir::Constness>
  833,638  ???:<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_query_deserialization::<rustc_query_system::query::plumbing::try_load_from_disk_and_cache_in_memory<rustc_query_impl::plumbing::QueryCtxt, rustc_span::def_id::DefId, rustc_hir::hir::Constness>::{closure
 -738,304  ???:<rustc_query_impl::on_disk_cache::OnDiskCache>::try_load_query_result::<()>
  705,344  ???:rustc_query_impl::plumbing::try_load_from_disk::<()>
  584,339  ???:<rustc_query_system::query::caches::DefaultCache<rustc_span::def_id::DefId, rustc_hir::hir::Constness> as rustc_query_system::query::caches::QueryCache>::iter
 -558,531  ???:rustc_query_system::query::plumbing::get_query::<rustc_query_impl::queries::hir_owner_parent, rustc_query_impl::plumbing::QueryCtxt>
  504,729  ???:<core::iter::adapters::map::Map<core::iter::adapters::map::Map<core::iter::adapters::enumerate::Enumerate<core::slice::iter::Iter<rustc_query_system::dep_graph::dep_node::DepNode<rustc_middle::dep_graph::dep_node::DepKind>>>, <rustc_index::vec::IndexVec<rustc_query_system::dep_graph::serialized::SerializedDepNodeIndex, rustc_query_system::dep_graph::dep_node::DepNode<rustc_middle::dep_graph::dep_node::DepKind>>>::iter_enumerated::{closure
  451,748  ???:<rustc_metadata::rmeta::encoder::EncodeContext>::encode_def_ids

compiler-errors · 2022-10-19T14:10:23Z

I can put up a PR to fix or revert the perf regression, since it's just a clean up and not actually fixing anything..

Revert "Unify tcx.constness and param env constness checks" Too much of a perf regression rust-lang#102975 (comment), and an attempt in rust-lang#103263 didn't fix it except for just a tiny bit. This change isn't really needed (see rust-lang#102830 (comment)), so this should be an easy revert.

Revert "Unify tcx.constness and param env constness checks" Too much of a perf regression rust-lang/rust#102975 (comment), and an attempt in #103263 didn't fix it except for just a tiny bit. This change isn't really needed (see rust-lang/rust#102830 (comment)), so this should be an easy revert.

Rollup of 7 pull requests Successful merges: - rust-lang#102623 (translation: eager translation) - rust-lang#102719 (Enforce alphabetical sorting with tidy) - rust-lang#102830 (Unify `tcx.constness` query and param env constness checks) - rust-lang#102883 (Fix stabilization of `feature(half_open_range_patterns)`) - rust-lang#102927 (Fix `let` keyword removal suggestion in structs) - rust-lang#102936 (rustdoc: remove unused CSS `nav.sum`) - rust-lang#102940 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

davidtwco and others added 25 commits October 10, 2022 13:32

macros: tidy up lint changes

febbf71

Small tweaks to changes made in a previous PR, unrelated to eager translation. Signed-off-by: David Wood <[email protected]>

macros: #[subdiagnostic(eager)]

291a473

Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <[email protected]>

query_system: finish migration

113e943

Using eager translation, migrate the remaining repeated cycle stack diagnostic. Signed-off-by: David Wood <[email protected]>

Fix stabilization of feature(half_open_range_patterns)

d17a69e

Fix let removal suggestion in struct

f9d3c83

rustdoc: remove unused CSS nav.sum

87060c4

This was added in 4fd061c, but never actually used.

rustdoc: merge identical CSS selectors

46169e6

Update books

f8048aa

Unify tcx.constness and param env constness checks

c646c4d

TyAlias needs encoded constness too, for layout computation in rustdoc

bef8681

Add tidy directoy tidy-alphabetical

0e38673

It can be used to ensure that a list of things is sorted alphabetically. It goes off lines, but contains several heuristics to work with normal Rust code (looking at indentation, ignoring comments and attributes).

Use tidy-alphabetical in the compiler

7bfef19

Error if tidy-alphabetical-end was not found

ce35609

Rollup merge of rust-lang#102936 - notriddle:notriddle/nav-sum, r=Dyl…

dcf7052

…an-DPC rustdoc: remove unused CSS `nav.sum` This was added in 4fd061c, but never actually used.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 12, 2022

bors merged commit c0983a9 into rust-lang:master Oct 12, 2022

rustbot added this to the 1.66.0 milestone Oct 12, 2022

rustbot added the perf-regression Performance regression. label Oct 12, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022

compiler-errors mentioned this pull request Oct 20, 2022

Revert "Unify tcx.constness and param env constness checks" #103284

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #102975

Rollup of 7 pull requests #102975

Dylan-DPC commented Oct 12, 2022

Dylan-DPC commented Oct 12, 2022

bors commented Oct 12, 2022

bors commented Oct 12, 2022

bors commented Oct 12, 2022

rust-timer commented Oct 12, 2022

rust-timer commented Oct 12, 2022

Mark-Simulacrum commented Oct 18, 2022

rust-timer commented Oct 18, 2022

rust-timer commented Oct 18, 2022

rylev commented Oct 19, 2022

compiler-errors commented Oct 19, 2022

Rollup of 7 pull requests #102975

Rollup of 7 pull requests #102975

Conversation

Dylan-DPC commented Oct 12, 2022

Dylan-DPC commented Oct 12, 2022

bors commented Oct 12, 2022

bors commented Oct 12, 2022

bors commented Oct 12, 2022

rust-timer commented Oct 12, 2022

rust-timer commented Oct 12, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Mark-Simulacrum commented Oct 18, 2022

rust-timer commented Oct 18, 2022

rust-timer commented Oct 18, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

rylev commented Oct 19, 2022

compiler-errors commented Oct 19, 2022