Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #102726

Merged
merged 13 commits into from
Oct 6, 2022
Merged

Rollup of 5 pull requests #102726

merged 13 commits into from
Oct 6, 2022

Commits on Oct 5, 2022

  1. Configuration menu
    Copy the full SHA
    a955ef2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    66c8c5a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    61cf3bf View commit details
    Browse the repository at this point in the history
  4. use smaller span

    TaKO8Ki committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    760279f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b7c42c5 View commit details
    Browse the repository at this point in the history
  6. add test for issue 82633

    Rageking8 committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    65c0e68 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ea38370 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3cb03cb View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Configuration menu
    Copy the full SHA
    5f5b7b8 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#102693 - BlackHoleFox:revert-apple-entropy-…

    …changes, r=thomcc
    
    Revert "Use getentropy when possible on all Apple platforms"
    
    Per rust-lang#102643, This reverts commit 3fc35b5 to avoid breaking any Rust on iOS users.
    
    Closes rust-lang#102643
    matthiaskrgr authored Oct 6, 2022
    Configuration menu
    Copy the full SHA
    6d8cea6 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#102694 - compiler-errors:fn-to-method, r=da…

    …vidtwco
    
    Suggest calling method if fn does not exist
    
    I tried to split this up into two commits, the first where we stash the resolution error until typeck (which causes a bunch of diagnostics changes because the ordering of error messages change), then the second commit is the actual logic that actually implements the suggestion.
    
    I am not in love with the presentation of the suggestion, so I could use some advice for how to format the actual messaging.
    
    r? diagnostics
    
    Fixes rust-lang#102518
    matthiaskrgr authored Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a9b3441 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#102708 - TaKO8Ki:improve-eqeq-suggestion, r…

    …=estebank
    
    Suggest `==` to wrong assign expr
    
    Given the following code:
    
    ```rust
    fn main() {
        let x = 3;
        let y = 3;
        if x == x && y = y {
            println!("{}", x);
        }
    }
    ```
    
    Current output is:
    
    ```
    error[E0308]: mismatched types
     --> src/main.rs:4:18
      |
    4 |     if x == x && y = y {
      |                  ^ expected `bool`, found integer
    
    error[E0308]: mismatched types
     --> src/main.rs:4:8
      |
    4 |     if x == x && y = y {
      |        ^^^^^^^^^^^^^^^ expected `bool`, found `()`
    ```
    
    This adds a suggestion:
    
    ```diff
    error[E0308]: mismatched types
     --> src/main.rs:6:18
      |
    6 |     if x == x && y = y {
      |                  ^ expected `bool`, found integer
    
    error[E0308]: mismatched types
     --> src/main.rs:6:8
      |
    6 |     if x == x && y = y {
      |        ^^^^^^^^^^^^^^^ expected `bool`, found `()`
      |
    + help: you might have meant to compare for equality
    +   |
    + 6 |     if x == x && y == y {
    +   |                     +
    ```
    
    And this fixes a part of rust-lang#97469
    matthiaskrgr authored Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0512a06 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#102710 - Rageking8:add-test-for-issue-82633…

    …, r=estebank
    
    Add test for issue 82633
    
    Fixes rust-lang#82633
    
    r? `@estebank`
    
    The current stderr looks slightly different from [source](https://github.com/rust-lang/rust/pull/83915/files#diff-8c64c576ccaceb816e71d2279a6ee4bf79211bc06f55c46dda3f98a18748ad7a), so I used the latest one from nightly. Do let me know if anything is wrong.
    matthiaskrgr authored Oct 6, 2022
    Configuration menu
    Copy the full SHA
    b7642fb View commit details
    Browse the repository at this point in the history