Allow parsing foreign impl blocks
#102376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-compiler
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
This comment has been minimized.
This comment has been minimized.
maurer
force-pushed
the
permit-foreign-impl
branch
from
9c3c503
to
375246a
Compare
This comment has been minimized.
This comment has been minimized.
maurer
force-pushed
the
permit-foreign-impl
branch
from
375246a
to
59a6552
Compare
This comment has been minimized.
This comment has been minimized.
Allow `impl` blocks in foreign modules for more ergonomic use in macros. `impl` blocks still have no meaning in foreign modules and will cause an error if still present during lowering. Also adds explicit tests for the previous similar foreign module macro extensions to ensure that neither this nor those are accepted or crash the compiler when *not* fed to a macro.
maurer
force-pushed
the
permit-foreign-impl
branch
from
59a6552
to
f728939
Compare
|
I'm not sure they'll accept this, given that #78849 was rejected. Maybe one could generally make parsing weaker for attr proc macros: #78849 (comment) Edit: obviously good C++ compatibility is more important than postfix macros, but the general argument of not adding even more exceptions to the tokens, and this seems to be a big exception, still exists. |
|
I’m thinking that this probably wants an compiler team MCP with all the votes and such before this can land. |
|
☔ The latest upstream changes (presumably #102461) made this pull request unmergeable. Please resolve the merge conflicts. |
nagisa
added
S-waiting-on-author
rustbot
added
the
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow parsing foreign
implblocks for use by proc macros.This allows more ergonomic description of methods and associated functions both when describing rust types to be exported and when importing class-like objects from other languages.
My primary motivation for this change is clean support for C++ static methods - this could be done with alternate syntax (e.g. explicit attributes to associate these functions with classes), but this seems much cleaner and potentially useful for interfacing with other languages beyond C++.
The Rust language itself remains unmodified - foreign
implblocks which make it past the macro expansion stage will not compile, and additional tests have been added to ensure this remains the case.#75857 is prior art on this kind of change, but is substantially less involved.
cc @dtolnay