cache collect_trait_impl_trait_tys

[compiler-errors]

Micro-optimization for RPITITs

[rust-highfive]

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 2ef3958fd09e9bbc03e8d38fb8afc7209dfc37bd with merge 379426e81938234c83195c9eb29e036e6c116da3...

[compiler-errors]

Shouldn't have much/any perf effect on non-RPITIT (return-position impl Trait in trait) code, but just checking...

[bors]

☀️ Try build successful - checks-actions
Build commit: 379426e81938234c83195c9eb29e036e6c116da3 (379426e81938234c83195c9eb29e036e6c116da3)

[rust-timer]

Queued 379426e81938234c83195c9eb29e036e6c116da3 with parent 88a1922, future comparison URL.

[rust-timer]

Finished benchmarking commit (379426e81938234c83195c9eb29e036e6c116da3): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-3.7%, -3.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[3.5%, 3.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[petrochenkov]

No difference it seems.
@rustbot author

[compiler-errors]

@petrochenkov I actually expected this to show no improvements, just wanted to double check this showed no regressions for code that didn't use these queries (but also I didn't expect any). This will probably be a significant improvement for incremental code that does use return-position impl Trait in traits, but there's no test suites using that since it's experimental.

I would still like to land this though, since it's along the same lines as caching the type_of query but for RPITIT.

@rustbot ready

[petrochenkov]

Ok, I see.
@bors r+ rollup=maybe

[bors]

📌 Commit 4cdf264 has been approved by petrochenkov

It is now in the queue for this repository.