Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc-Json: Correcty handle intra-doc-links to items without HTML page #101633

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

aDotInTheVoid
Copy link
Member

Closes #101531

I renamed the did field in ItemLink to more accurately describe what it does.

r? @jyn514

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 9, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2022

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2022
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comments!

src/librustdoc/clean/types.rs Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Sep 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2022

📌 Commit 2c17099 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 10, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#101413 (Use RelocModel::Pic for UEFI targets)
 - rust-lang#101595 (Fix ICE report flags display.)
 - rust-lang#101616 (Adapt test for msan message change)
 - rust-lang#101624 (rustdoc: remove unused CSS `#search { position: relative }`)
 - rust-lang#101633 (Rustdoc-Json: Correcty handle intra-doc-links to items without HTML page)
 - rust-lang#101634 (Rustdoc-Json Tests: Use ``@is`` and ``@ismany`` more often.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2566e31 into rust-lang:master Sep 10, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc-Json: link may be set to the ID of the item containing the link target
5 participants