Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs related to readonly and set readonly to improve clarity of their behaviour #101599

Closed

Conversation

Firstyear
Copy link
Contributor

Fixes #74895

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 9, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2022
@Timmmm
Copy link
Contributor

Timmmm commented Sep 10, 2022

See also #101599 - I wrote it like a year ago, then forgot to upload it, finally did it today and then saw this!

@JohnTitor
Copy link
Member

See also #101599 - I wrote it like a year ago, then forgot to upload it, finally did it today and then saw this!

Did you mean #101644?

@Timmmm
Copy link
Contributor

Timmmm commented Sep 15, 2022

Ah oops, yes!

@Firstyear
Copy link
Contributor Author

Closed in favour of #101644

@thomcc
Copy link
Member

thomcc commented Oct 23, 2022

@Firstyear Did you mean to close this with that comment?

@Firstyear
Copy link
Contributor Author

Yes, sorry!

@Firstyear Firstyear closed this Oct 23, 2022
@Firstyear Firstyear deleted the 74895-improve-readonly-docs branch October 23, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permissions::readonly() doesn't behave as expected with files
7 participants