Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Fuchsia zxdb debugging walkthrough to docs #101340

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

andrewpollack
Copy link
Member

Adding zxdb docs to walkthrough to show debugging steps

@rust-highfive
Copy link
Collaborator

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2022
@andrewpollack
Copy link
Member Author

r? @tmandry

cc @djkoloski

@rust-highfive rust-highfive assigned tmandry and unassigned JohnTitor Sep 2, 2022
@tmandry
Copy link
Member

tmandry commented Sep 14, 2022

Before landing, please rebase on master and make sure the merge commit is removed. (We generally reserve merge commits for bors and don't allow them in PRs; there's more info on this page: https://rustc-dev-guide.rust-lang.org/git.html#rebasing-and-conflicts.)

Copy link
Member

@tmandry tmandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comment

@bors delegate+ rollup

@tmandry
Copy link
Member

tmandry commented Sep 16, 2022

@bors delegate+ rollup

@bors
Copy link
Contributor

bors commented Sep 16, 2022

✌️ @andrewpollack can now approve this pull request

@andrewpollack
Copy link
Member Author

@bors r=tmandry

@bors
Copy link
Contributor

bors commented Sep 16, 2022

📌 Commit 2b8886f has been approved by tmandry

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101340 (Adding Fuchsia zxdb debugging walkthrough to docs)
 - rust-lang#101741 (Adding needs-unwind arg to applicable compiler ui tests)
 - rust-lang#101782 (Update `symbol_mangling` diagnostics migration)
 - rust-lang#101878 (More simple formatting)
 - rust-lang#101898 (Remove some unused CSS rules)
 - rust-lang#101911 (rustdoc: remove no-op CSS on `.source .content`)
 - rust-lang#101914 (rustdoc-json-types: Document that ResolvedPath can also be a union)
 - rust-lang#101921 (Pass --cfg=bootstrap for rustdoc for proc_macro crates)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fffb7f2 into rust-lang:master Sep 17, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 17, 2022
@tmandry tmandry added the O-fuchsia Operating system: Fuchsia label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants