Replaced empty destructors with NonCopyable #7427 #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -340,13 +340,10 @@ pub struct Parser { | |||
| mod_path_stack: @mut ~[@str], | |||
| /// Stack of spans of open delimiters. Used for error message. | |||
| open_braces: @mut ~[Span] | |||
| /// removed empty drop function and added a priv new_field of type std::util::NonCopyable | |||
There was a problem hiding this comment.
This comment isn't needed, but we do want to keep the /* do not copy the parser; its state is tied to outside state */ one, so please put that one here.
|
Looks good! But could you squash the 6 commits into 1? |
|
Done rebasing ! |
bors
added a commit
that referenced
this pull request
Oct 29, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 12, 2023
Partially revert rust-lang#9701 This partially reverts rust-lang#9701 due to rust-lang#10134 r? `@flip1995` changelog: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.