Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap: Initialized submodules no longer eagerly updated by running x.py #99083

Closed
bjorn3 opened this issue Jul 9, 2022 · 1 comment · Fixed by #100008
Closed

Bootstrap: Initialized submodules no longer eagerly updated by running x.py #99083

bjorn3 opened this issue Jul 9, 2022 · 1 comment · Fixed by #100008
Assignees
@jyn514
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jul 9, 2022

maybe_update_submodules should already do this, but

rust/src/bootstrap/lib.rs

Lines 628 to 635 in c4693bc

let mut bootstrap_submodules: Vec<&str> = vec![
"src/tools/rust-installer",
"src/tools/cargo",
"src/tools/rls",
"src/tools/miri",
"library/backtrace",
"library/stdarch",
];
hasn't been kept in sync with the removal of identical functionality from x.py. Also rust-analyzer is only updated when vendoring is enabled.
@bjorn3 bjorn3 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Jul 9, 2022
@matthiaskrgr
Copy link
Member

I think this was caused by #97513

@jyn514 jyn514 added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Jul 9, 2022
@jyn514 jyn514 mentioned this issue Aug 1, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 2, 2022
@matthiaskrgr
Rollup merge of rust-lang#100008 - jyn514:eager-submodules, r=bjorn3
4fbe53f 
Update all pre-cloned submodules on startup

Fixes rust-lang#99083
@bors bors closed this as completed in f2164c3 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyn514 jyn514

Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update all pre-cloned submodules on startup jyn514/rust
3 participants
@matthiaskrgr @bjorn3 @jyn514