-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap build failing on Windows (MSVC) #98546
Comments
@BlaCoiso do you want to make a PR with that patch? :) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jun 27, 2022
Fix builds on Windows (closes rust-lang#98546) closes rust-lang#98546
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jun 27, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#97389 (Improve memory ordering diagnostics) - rust-lang#97780 (Check ADT field is well-formed before checking it is sized) - rust-lang#98530 (compiletest: add issue number param to `known-bug`) - rust-lang#98556 (Fix builds on Windows (closes rust-lang#98546)) - rust-lang#98561 (Fix spelling in SAFETY comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit 418b1fa broke builds on Windows as
llvm-config
has a.exe
extension butrust/src/bootstrap/native.rs
Lines 163 to 164 in 418b1fa
does not take that into account, resulting in a file not found error and bootstrap panicking.
Patching line 163 with
fixes the build.
The text was updated successfully, but these errors were encountered: