-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
select_nth documentation is insufficient #97982
Labels
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
Comments
asher-gh
added a commit
to asher-gh/rust
that referenced
this issue
Jun 14, 2022
GuillaumeGomez
added
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
and removed
C-bug
Category: This is a bug.
labels
Jun 17, 2022
@rustbot claim |
Oh, it seems there's already an active PR for this. Sorry! |
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this issue
Sep 25, 2022
Clarify `[T]::select_nth_unstable*` return values In cases where the nth element is not unique within the slice, it is not correct to say that the values in the returned triplet include ones for "all elements" less/greater than that at the given index: indeed one (or more) such values would then also contain elements equal to that at the given index. The text proposed here clarifies exactly what is returned, but in so doing it is also documenting an implementation detail that previously wasn't detailed: namely that the returned slices are slices into the reordered slice. I don't think this can be contentious, because the lifetimes of those returned slices are bound to that of the original (now reordered) slice—so there really isn't any other reasonable implementation that could have this behaviour; but nevertheless it's probably best if `@rust-lang/libs-api` give it a nod? Fixes rust-lang#97982 r? `@m-ou-se` `@rustbot` label +A-docs +C-bug +T-libs-api -T-libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
The documentation's description of the return values is slightly incorrect.
rust/library/core/src/slice/mod.rs
Lines 2631 to 2633 in c845946
The following code however, produces
([1, 1], 1, [1, 1])
:(playground link: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3c68d77916745c6442866324d675755d)
The text was updated successfully, but these errors were encountered: