Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: TLS linker issues #96132

Closed
Mark-Simulacrum opened this issue Apr 16, 2022 · 4 comments
Closed

regression: TLS linker issues #96132

Mark-Simulacrum opened this issue Apr 16, 2022 · 4 comments
Labels
A-thread-locals Area: Thread local storage (TLS) P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.61.0

Comments

@Mark-Simulacrum
Copy link
Member

Sample error:

 /usr/bin/ld: _ZN12actix_server6worker17MAX_CONNS_COUNTER7__getit5__KEY17h775958233b530a84E: TLS definition in /opt/rustwide/target/debug/deps/libactix_server-e79ae2ac501e8d6f.rlib(actix_server-e79ae2ac501e8d6f.actix_server.1b875993-cgu.14.rcgu.o) section .tbss._ZN12actix_server6worker17MAX_CONNS_COUNTER7__getit5__KEY17h775958233b530a84E mismatches non-TLS reference in /opt/rustwide/target/debug/deps/libactix_server-e79ae2ac501e8d6f.rlib(actix_server-e79ae2ac501e8d6f.actix_server.1b875993-cgu.9.rcgu.o)
[INFO] [stdout]           /usr/bin/ld: /opt/rustwide/target/debug/deps/libactix_server-e79ae2ac501e8d6f.rlib: error adding symbols: bad value

I suspect this is quite common -- it looks to be majority of the build failed "unknown" errors (~1000) in Crater results (https://crater-reports.s3.amazonaws.com/beta-1.61-1/index.html).
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. A-thread-locals Area: Thread local storage (TLS) labels Apr 16, 2022
@Mark-Simulacrum Mark-Simulacrum added this to the 1.61.0 milestone Apr 16, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 16, 2022
@Mark-Simulacrum
Copy link
Member Author

I suspect this is due to #94373, so we'll probably want to verify that and revert at least for 1.61 (pending further investigation). But mostly suspecting just due to it being an obvious TLS-related change in 1.61 (could also be #92123, but seems pretty unlikely).

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Apr 16, 2022
Closed
@ehuss
Copy link
Contributor

ehuss commented Apr 17, 2022

I verified it bisected to #94373 (cc @erikdesjardins).

This was referenced Apr 17, 2022
Merged
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 17, 2022
@bors
Auto merge of rust-lang#96138 - erikdesjardins:revertinl, r=Mark-Simu…
2431a97 
…lacrum

[beta] Revert: Make TLS __getit #[inline(always)] on non-Windows

Fixes rust-lang#96132

r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 17, 2022
@bors
Auto merge of rust-lang#96139 - erikdesjardins:revertinl2, r=Mark-Sim…
ec77f25 
…ulacrum

Revert: Make TLS __getit #[inline(always)] on non-Windows

re rust-lang#96132

r? `@Mark-Simulacrum`
@apiraino
Copy link
Contributor

Assigning priority since the comments indicate that it could affect many crates (Wg-prioritization Zulip thread)

@rustbot label -I-prioritize +P-high

@rustbot rustbot added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Apr 20, 2022
@Mark-Simulacrum
Copy link
Member Author

Since we reverted the PR (across beta and master) I'll go ahead and close.

@tabokie tabokie mentioned this issue Jun 13, 2022
Merged
ti-chi-bot pushed a commit to tikv/tikv that referenced this issue Jun 15, 2022
@tabokie
tests: ignore env var dependent tests at runtime (#12805)
2fbf7ee 
ref rust-lang/cargo#10250, close #12804, ref rust-lang/rust#68007, ref rust-lang/rust#96132

Signed-off-by: tabokie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-thread-locals Area: Thread local storage (TLS) P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

No branches or pull requests
4 participants
@ehuss @Mark-Simulacrum @apiraino @rustbot