Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustpkg fetching remote packages is broken #9193

Closed
catamorphism opened this issue Sep 14, 2013 · 3 comments · Fixed by #9741
Closed

rustpkg fetching remote packages is broken #9193

catamorphism opened this issue Sep 14, 2013 · 3 comments · Fixed by #9741

Comments

@catamorphism
Copy link
Contributor

A recent change of mine broke extern mod foo = github.com/foo/bar/blat;, because now util::find_and_install_dependencies (correctly) tries to find what workspace the package is in before installing it, but (incorrectly) gives up if it's not found locally. The code should be refactored so that the git fetch step can happen before installing.

This regressed because, unfortunately, there are no automated rustpkg tests that fetch a package from a remote repository (since network connectivity was unreliable on the bots).

@ghost ghost assigned catamorphism Sep 14, 2013
@alexcrichton
Copy link
Member

Would it be possible to have these tests on the bots, but ignore network failures? Ideally we'd do something like raise on the test::skip condition or something like that to indicate that the test should be skipped (and provide different output than if it passed), but it would be awesome to at least test this functionality most of the time.

@catamorphism
Copy link
Contributor Author

The problem is that because of #9001, there isn't a simple way to determine what unhandled condition a sub-task failed with. Maybe someone else has a bright idea...

@catamorphism
Copy link
Contributor Author

For testing, @cmr suggested running a local git server on each of the bots, which seems possible, though a bit of a pain in the neck since we'd have to run it separately on each.

@catamorphism catamorphism removed their assignment Jun 16, 2014
Jarcho pushed a commit to Jarcho/rust that referenced this issue Aug 29, 2022
Jarcho pushed a commit to Jarcho/rust that referenced this issue Aug 29, 2022
Fix if_let_mutex not checking Mutexes behind refs

Fixes rust-lang#9193

We can always peel references because we are looking for a method-call, for which autoderef applies.

---

changelog: [`if_let_mutex`]: detect calls to `Mutex::lock()` if mutex is behind a ref
changelog: [`if_let_mutex`]: Add labels to the two instances of the same Mutex that will deadlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants