-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display of enums with subfields #90061
Comments
I'm pretty sure I got rid of the variant fields toggle a couple months ago; those docs were generated back in June. So I think the toggle-related problems have already been fixed :) EDIT: I removed the toggles in #87332. |
Confirmed. Here's what it looks like built with nightly: Thanks for fixing the toggles! |
I fully agree with this. I find the current styling very confusing to look at. Also, I think we should replace "Fields of Comment" with just "Fields" — it's more consistent with other parts of the docs and less redundant. |
…d,GuillaumeGomez Improve display of enum variants Use h3 and h4 for the variant name and the "Fields" subheading. Remove the "of T" part of the "Fields" subheading. Remove border-bottom from "Fields" subheading. Move docblock below "Fields" listing. Fixes rust-lang#90061 Demo: https://jacob.hoffman-andrews.com/rust/xmlparser-updated/xmlparser/enum.Token.html#variants https://jacob.hoffman-andrews.com/rust/fix-enum-variants/std/io/enum.ErrorKind.html#variants https://jacob.hoffman-andrews.com/rust/fix-enum-variants/std/result/enum.Result.html#variants r? `@camelid`
…d,GuillaumeGomez Improve display of enum variants Use h3 and h4 for the variant name and the "Fields" subheading. Remove the "of T" part of the "Fields" subheading. Remove border-bottom from "Fields" subheading. Move docblock below "Fields" listing. Fixes rust-lang#90061 Demo: https://jacob.hoffman-andrews.com/rust/xmlparser-updated/xmlparser/enum.Token.html#variants https://jacob.hoffman-andrews.com/rust/fix-enum-variants/std/io/enum.ErrorKind.html#variants https://jacob.hoffman-andrews.com/rust/fix-enum-variants/std/result/enum.Result.html#variants r? `@camelid`
https://docs.rs/xmlparser/0.13.4/xmlparser/enum.Token.html
(I've expanded one of the "Show fields" toggles in the above screenshot)
Problems:
<h3>
, but "Comment" is not a heading at all. This should be reversed.EDIT(camelid): The toggles seen in the image above have already been removed. See #90061 (comment) for an updated screenshot.
The text was updated successfully, but these errors were encountered: