-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: failing unit tests in libstd\unstable\dynamic_lib.rs #8818
Comments
Does Windows export cos in its standard math libraries? Otherwise, the problem would be that we didn't link in the math libraries. Regardless, the test should use it's own self contained function for this. I'll fix this quickly. |
Triage update: still needs fixing. Should be easy, though. Just pick a random windows lib to load and check, rather than libm. |
The fix here is seemingly not so simple. Functions in the exe appear to need DllExport to be loaded, and we don't apply that attribute (except to main, for odd reasons). |
This test attempts to get the address of This doesn't work the same way on Windows, where GetProcAddress() searches only the module it was given. It would be hard to emulate dlsym's behavior on Windows, and besides it's unclear under which circumstances this is useful. Closing. |
Use the traits added to the Rust 2021 Edition prelude Follow up rust-lang#96861. This PR uses the traits added to the Rust 2021 Edition prelude. > The `TryInto`, `TryFrom` and `FromIterator` traits are now part of the prelude. https://doc.rust-lang.org/edition-guide/rust-2021/prelude.html --- changelog: none
test_loading_cosine
task <unnamed> failed at 'Could not load function cos: Error code 127u', C:\Rust\src\libstd\unstable\dynamic_lib.rs:106
The text was updated successfully, but these errors were encountered: