Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#85022 #85027

Closed
rust-highfive opened this issue May 7, 2021 · 3 comments · Fixed by #85034 or #85072
Closed

miri no longer builds after rust-lang/rust#85022 #85027

rust-highfive opened this issue May 7, 2021 · 3 comments · Fixed by #85034 or #85072
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

rust-highfive commented May 7, 2021 •
edited by rustbot
Loading

Hello, this is your friendly neighborhood mergebot.
After merging PR #85022, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @JohnTitor, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels May 7, 2021
@ghost
Copy link

ghost commented May 7, 2021 •
edited by ghost
Loading

Some error message changes (cc #84972) broke Miri, but some "null pointer is not allowed for this operation" changes look... wrong?

For example:
https://github.com/rust-lang/miri/blob/ee8dbbc40f8d1fe2805fd62b5cf32b9d3e0b62ac/tests/compile-fail/dangling_pointers/wild_pointer_deref.rs#L3
https://github.com/rust-lang/miri/blob/ee8dbbc40f8d1fe2805fd62b5cf32b9d3e0b62ac/tests/compile-fail/dangling_pointers/deref-invalid-ptr.rs#L6
https://github.com/rust-lang/miri/blob/ee8dbbc40f8d1fe2805fd62b5cf32b9d3e0b62ac/tests/compile-fail/function_pointers/cast_int_to_fn_ptr.rs#L9
(and many more)

They are all not 0x0.

@RalfJung
Copy link
Member

RalfJung commented May 7, 2021

Yeah my patch makes no sense... working on a fix.

@RalfJung RalfJung mentioned this issue May 7, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 7, 2021
@Dylan-DPC
Rollup merge of rust-lang#85034 - RalfJung:null-ptr, r=oli-obk
a1ee170 
fix null pointer error messages

I got the `match` in rust-lang#84972 wrong, this fixes that.
Also avoid redundant "inbounds test failed:" prefix.

Should fix rust-lang#85027

r? `@oli-obk`
@bors bors closed this as completed in bba8f99 May 8, 2021
@ghost
Copy link

ghost commented May 8, 2021

I don't think the toolstate is fixed:
miri - test fail

But it's just error message differences:
https://github.com/rust-lang-ci/rust/runs/2532090745#step:24:9456

@rustbot claim

@rustbot rustbot assigned ghost and unassigned eddyb, RalfJung and oli-obk May 8, 2021
@ghost ghost mentioned this issue May 8, 2021
Merged
@RalfJung RalfJung reopened this May 8, 2021
bors added a commit to rust-lang/miri that referenced this issue May 8, 2021
@bors
Auto merge of #1790 - hyd-dev:rustup, r=RalfJung
38b5f23 
Update pointer error messages

cc rust-lang/rust#85027
@ghost ghost mentioned this issue May 8, 2021
Merged
@bors bors closed this as completed in ff34b91 May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix null pointer error messages RalfJung/rust
Update Miri
4 participants
@eddyb @RalfJung @oli-obk @rust-highfive