Wrong pub modifier in each function of trait documentation

[tesuji]

The documentation of Iterator trait on 1.49.0 (current stable) doesn't contain pub modifier in function declaration of that trait.

However, on beta and nightly, there is pub modifier.

This is wrong because you cannot use pub modifier for each method/function in Trait definition.
Why is this important? People copy the method/function declaration in the documentation to their code
and see the compiler error: error[E0449]: unnecessary visibility qualifier.

Meta

rustc --version --verbose:

rustc 1.49.0 (e1884a8e3 2020-12-29)
binary: rustc
commit-hash: e1884a8e3c3e813aada8254edfa120e85bf5ffca
commit-date: 2020-12-29
host: x86_64-unknown-linux-gnu
release: 1.49.0

cc @jyn514 I think this might relate to some changes in visibility around macros ?

[jyn514]

Yes, this needs the same fix as #77820 (comment) (in particular

rust/src/librustdoc/clean/mod.rs

Lines 1732 to 1733 in 0e1a302

	// Don't show `pub` for fields on enum variants; they are always public
	Item { visibility: self.vis.clean(cx), ..what_rustc_thinks }

should work).

[camelid]

Self-assigning because this is a beta regression.

[camelid]

Note that this also occurs for the impl's docs.

[hameerabbasi]

Removed I-prioritize since this was fixed.

[tesuji]

In nightly, trait methods still rendered as pub fn:

Is there something wrong to Rust release or the bug still exists ?

[jyn514]

Hmm, maybe it was only fixed for items in the local crate. @lzutao do you have time to come up with an MCVE? I expect it's related to cross-crate re-exports.

[tesuji]

Your guess sounds right. With core link (https://doc.rust-lang.org/nightly/core/iter/trait.ExactSizeIterator.html#provided-methods), things are normal.

[camelid]

I don't think I'll have time to fix this second part soon, so unassigning myself.

[camelid]

Assigning P-medium and removing I-prioritize as discussed in the prioritization working group.

[jyn514]

I think

rust/src/librustdoc/clean/mod.rs

Line 1156 in dab3a80

impl Clean<Item> for ty::AssocItem {

is the cross-crate case.

[pietroalbini]

Fix backported to 1.50.0 and landed in 1.51.0, closing this.

[tesuji]

Please reopen. The issue is not entirely fixed for cross-crate trait reexport case.

[camelid]

The cross-crate issue is now on stable. @rustbot label: +regression-from-stable-to-stable -regression-from-stable-to-beta

[Stupremee]

@rustbot claim