Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atty crate in libtest instead of rolling our own #80937

Closed
camelid opened this issue Jan 12, 2021 · 15 comments
Closed

Use atty crate in libtest instead of rolling our own #80937

camelid opened this issue Jan 12, 2021 · 15 comments
Assignees
Labels
A-libtest Area: `#[test]` / the `test` library C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Jan 12, 2021

cc #80888
cc @jyn514

This issue has been assigned to @mattwilkinsonn via this comment.

@camelid camelid added A-libtest Area: `#[test]` / the `test` library C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 12, 2021
@jyn514
Copy link
Member

jyn514 commented Jan 12, 2021

@camelid what happened to #42732 (comment) ?

@nagisa
Copy link
Member

nagisa commented Jan 12, 2021

winapi has since been improved to no longer imply long build times at the very least.

@camelid
Copy link
Member Author

camelid commented Jan 12, 2021

But I think we should probably use atty since it's so widely used.

@artorias111
Copy link

Hey! Is this a good issue if I'm just getting used to contribute to various projects. Not really familiar with the rust codebase but would like to try if I can contribute.

@jyn514
Copy link
Member

jyn514 commented Jan 23, 2021

@artorias111 yes, this would be a good first issue I think. I'm not 100% convinced we should make the change, but the implementation is easy, just add atty as a dependency and use it in libtest: #80897 (comment)

@artorias111
Copy link

@jyn514 sure, I'll give it a try then

@diohabara
Copy link

@jyn514
Those participated do not seem to be working on this issue, and the related PR is also inactive.
So, can I assign this task to myself?

@diohabara
Copy link

I'll do it for now, but please let me know if you have any problems.

@diohabara
Copy link

@rustbot claim

@vramana
Copy link
Contributor

vramana commented Mar 25, 2022

@diohabara Are you still interested to work on this? Or can I claim it?

@jyn514
Copy link
Member

jyn514 commented Mar 25, 2022

#91121 is making good progress; I don't think it makes sense to duplicate work.

@camelid
Copy link
Member Author

camelid commented Mar 25, 2022

@rustbot assign @mattwilkinsonn

@rustbot rustbot self-assigned this Mar 25, 2022
@joshtriplett
Copy link
Member

#98033 just merged.

@saethlin
Copy link
Member

@joshtriplett Should this have been closed by #98033?

@ChrisDenton
Copy link
Member

I believe so.

@ChrisDenton ChrisDenton closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-libtest Area: `#[test]` / the `test` library C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
10 participants