-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use atty
crate in libtest instead of rolling our own
#80937
Comments
@camelid what happened to #42732 (comment) ? |
winapi has since been improved to no longer imply long build times at the very least. |
But I think we should probably use |
Hey! Is this a good issue if I'm just getting used to contribute to various projects. Not really familiar with the rust codebase but would like to try if I can contribute. |
@artorias111 yes, this would be a good first issue I think. I'm not 100% convinced we should make the change, but the implementation is easy, just add |
@jyn514 sure, I'll give it a try then |
@jyn514 |
I'll do it for now, but please let me know if you have any problems. |
@rustbot claim |
@diohabara Are you still interested to work on this? Or can I claim it? |
#91121 is making good progress; I don't think it makes sense to duplicate work. |
@rustbot assign @mattwilkinsonn |
#98033 just merged. |
@joshtriplett Should this have been closed by #98033? |
I believe so. |
cc #80888
cc @jyn514
This issue has been assigned to @mattwilkinsonn via this comment.
The text was updated successfully, but these errors were encountered: