Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#77731 #77791

Closed
rust-highfive opened this issue Oct 10, 2020 · 6 comments · Fixed by #77824 or #77837
Closed

miri no longer builds after rust-lang/rust#77731 #77791

rust-highfive opened this issue Oct 10, 2020 · 6 comments · Fixed by #77824 or #77837
Assignees
@eddyb @RalfJung @oli-obk
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #77731, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @cuviper, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Oct 10, 2020
@cuviper
Copy link
Member

cuviper commented Oct 10, 2020

cc @Aaron1011, I saw you also mentioned that PR in rust-lang/miri#1578.

@Aaron1011
Copy link
Member

It looks like I set up the imports incorrectly in rust-lang/backtrace-rs#372 - they don't work when backtrace-rs is built as part of libstd. I'm working on a PR to fix it.

@RalfJung
Copy link
Member

Indeed this will require another backtrace-rs bump to be fixed.

I'm working on a PR to fix it.

Thanks!

@Aaron1011
Copy link
Member

Opened rust-lang/backtrace-rs#375

@RalfJung
Copy link
Member

Now we also have a build failure: #77649. But we cannot fix that while libbacktrace is broken.

@Aaron1011 Aaron1011 mentioned this issue Oct 11, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 11, 2020
@bors
Auto merge of rust-lang#77824 - Aaron1011:bump-backtrace-miri, r=Ralf…
06a079c 
…Jung

Bump backtrace-rs

Fixes rust-lang#77791

r? `@RalfJung`

cc `@alexcrichton`
@bors bors closed this as completed in 44fdfd6 Oct 11, 2020
@Aaron1011 Aaron1011 reopened this Oct 11, 2020
@Aaron1011
Copy link
Member

The build failure still needs to be fixed.

@RalfJung RalfJung mentioned this issue Oct 12, 2020
Merged
@bors bors closed this as completed in a8d6da3 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump backtrace-rs Aaron1011/rust
Bump miri Aaron1011/rust
6 participants
@cuviper @eddyb @RalfJung @oli-obk @Aaron1011 @rust-highfive