Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustpkg tests are broken on master #7249

Closed
Aatch opened this issue Jun 20, 2013 · 5 comments
Closed

rustpkg tests are broken on master #7249

Aatch opened this issue Jun 20, 2013 · 5 comments

Comments

@Aatch
Copy link
Contributor

Aatch commented Jun 20, 2013

The test in question is test_all and has been marked with #[ignore]. Seems to only happen on multi-host builds.

cc @catamorphism
@brson
Copy link
Contributor

brson commented Jun 20, 2013

Example: http://buildbot.rust-lang.org/builders/snap3-mac/builds/320

@ghost ghost assigned catamorphism Jun 20, 2013
@catamorphism
Copy link
Contributor

Ok, I'll look at it.

@alexcrichton
Copy link
Member

Probably the same bug as #7541

@catamorphism
Copy link
Contributor

I think this should be fixed. Pushing to try.

@catamorphism
Copy link
Contributor

Fixed by d9293d1

flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 17, 2021
@bors
Auto merge of rust-lang#7262 - Jarcho:while_let_on_iter_closure, r=xF…
07217e3 
…rednet,flip1995

fix `while_let_on_iterator` suggestion in a closure

fixes: rust-lang#7249

A future improvement would be to check if the closure is being used as `FnOnce`, in which case the original suggestion would be correct.

changelog: Suggest `&mut iter` inside a closure for `while_let_on_iterator`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @brson @Aatch @catamorphism