-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type aliases and mods of the same name in the same namespace should be forbidden #6936
Comments
The test still passes |
Visiting for triage. Nominating for backwards compat. |
accepted for P-backcompat-lang |
cc @aturon and rust-lang/rfcs#195, this looks like it may have interesting interactions with associated items and/or UFCS |
Nominating. This was marked P-backcompat-lang but not previously placed on a milestone. Do we need to do something here for beta? |
assigning to 1.0-beta milestone: we need to make a decision here and firm up our story about the namespace conflicts. |
Note that currently other types and modules don't clash, so that might be a bug too. |
This commit modifies resolve to prevent conflicts with typedef names in the same method that conflits are prevented with enum names. This is a breaking change due to the differing semantics in resolve, and any errors generated on behalf of this change require that a conflicting typedef, module, or structure to be renamed so they do not conflict. [breaking-change] Closes rust-lang#6936
This commit modifies resolve to prevent conflicts with typedef names in the same method that conflits are prevented with enum names. This is a breaking change due to the differing semantics in resolve, and any errors generated on behalf of this change require that a conflicting typedef, module, or structure to be renamed so they do not conflict. [breaking-change] Closes #6936
Refactor types r? `@flip1995` This is the last PR to close rust-lang#6724 🎉 Also, this fixes rust-lang#6936. changelog: `vec_box`: Fix FN in `const` or `static` changelog: `linkedlist`: Fix FN in `const` or `static` changelog: `option_option`: Fix FN in `const` or `static`
The tests for this crate compile ok:
This is incompatible with #6894, and should probably be forbidden.
The text was updated successfully, but these errors were encountered: