New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't infer regions in type checking #68261

Open

matthewjasper opened this issue Jan 15, 2020 · 1 comment

Labels

A-inference A-lifetimes A-NLL C-enhancement T-compiler

Contributor

matthewjasper commented Jan 15, 2020

This is a tracking issue for avoiding region inference in item body type checking. The goal would be to use ReErased where we currently use ReVar as much as possible.

The motivations for this are:

It would avoid doing region inference twice (once in typeck, once in borrowck).
It might improve caching since there are fewer distinct types.
It ensures that region inference cannot affect later passes.

cc @nikomatsakis

The text was updated successfully, but these errors were encountered:

matthewjasper added C-enhancement A-lifetimes A-inference A-NLL labels

Contributor Author

matthewjasper commented Jan 15, 2020 •

edited

Loading

The first steps towards this are #67681 and #65232

Some further steps are:

Erase regions in writeback.rs (Erase regions in writeback #69189)
Don't infer regions when checking function/const/static bodies, gated on -Zborrowck=mir
Don't visit expressions in regionck. This requires some work to ensure that we don't regress error messages.

Some related work would be

Remove ReScope ( Remove ReScope #72362)
Ensure that MIR doesn't contain unerased free regions (except for borrowck's copy)

jonas-schievink added the T-compiler label

matthewjasper mentioned this issue

Erase regions in writeback #69189

Merged

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#69189 - matthewjasper:erase-the-world, r=ni…

d895ceb

…komatsakis

Erase regions in writeback

Regions in `TypeckTables` (except canonicalized user annotations) are now erased. Further, we no longer do lexical region solving on item bodies with `-Zborrowck=mir`.

cc rust-lang#68261
r? @nikomatsakis

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#69189 - matthewjasper:erase-the-world, r=ni…

fe69360

…komatsakis

Erase regions in writeback

Regions in `TypeckTables` (except canonicalized user annotations) are now erased. Further, we no longer do lexical region solving on item bodies with `-Zborrowck=mir`.

cc rust-lang#68261
r? @nikomatsakis

Manishearth added a commit to Manishearth/rust that referenced this issue


          Rollup merge of rust-lang#69189 - matthewjasper:erase-the-world, r=ni…

59e1a3d

…komatsakis

Erase regions in writeback

Regions in `TypeckTables` (except canonicalized user annotations) are now erased. Further, we no longer do lexical region solving on item bodies with `-Zborrowck=mir`.

cc rust-lang#68261
r? @nikomatsakis

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#69189 - matthewjasper:erase-the-world, r=ni…

e069c31

…komatsakis

Erase regions in writeback

Regions in `TypeckTables` (except canonicalized user annotations) are now erased. Further, we no longer do lexical region solving on item bodies with `-Zborrowck=mir`.

cc rust-lang#68261
r? @nikomatsakis

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#69189 - matthewjasper:erase-the-world, r=ni…

1dfc89b

…komatsakis

Erase regions in writeback

Regions in `TypeckTables` (except canonicalized user annotations) are now erased. Further, we no longer do lexical region solving on item bodies with `-Zborrowck=mir`.

cc rust-lang#68261
r? @nikomatsakis

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#69189 - matthewjasper:erase-the-world, r=ni…

ecf19c3

…komatsakis

Erase regions in writeback

Regions in `TypeckTables` (except canonicalized user annotations) are now erased. Further, we no longer do lexical region solving on item bodies with `-Zborrowck=mir`.

cc rust-lang#68261
r? @nikomatsakis

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#69189 - matthewjasper:erase-the-world, r=ni…

3f583fc

…komatsakis

Erase regions in writeback

Regions in `TypeckTables` (except canonicalized user annotations) are now erased. Further, we no longer do lexical region solving on item bodies with `-Zborrowck=mir`.

cc rust-lang#68261
r? @nikomatsakis

matthewjasper mentioned this issue

Remove ReScope #72362

Merged

RalfJung added a commit to RalfJung/rust that referenced this issue


          Rollup merge of rust-lang#72362 - matthewjasper:remove-rescope, r=nik…

533b6ce

…omatsakis

Remove ReScope

`ReScope` is unnecessary now that AST borrowck is gone and we're erasing the results of region inference in function bodies. This removes about as much of the old regionck code as possible without having to enable NLL fully.

cc rust-lang#68261

r? @nikomatsakis

bors added a commit to rust-lang-ci/rust that referenced this issue


          Auto merge of rust-lang#72362 - matthewjasper:remove-rescope, r=nikom…

52b605c

…atsakis

Remove ReScope

`ReScope` is unnecessary now that AST borrowck is gone and we're erasing the results of region inference in function bodies. This removes about as much of the old regionck code as possible without having to enable NLL fully.

cc rust-lang#68261

r? @nikomatsakis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment