Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/run-make-fulldeps/pgo-branch-weights fails occasionally on CI #67746

Closed
JohnTitor opened this issue Dec 31, 2019 · 6 comments
Closed

test/run-make-fulldeps/pgo-branch-weights fails occasionally on CI #67746

JohnTitor opened this issue Dec 31, 2019 · 6 comments
Assignees
@michaelwoerister
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@JohnTitor
Copy link
Member

JohnTitor commented Dec 31, 2019 •
edited
Loading

You can see this test fails occasionally in some pull requests: https://github.com/rust-lang/rust/pulls?utf8=%E2%9C%93&q=is%3Apr+pgo-branch-weights

I don't think this is due to PR changes. Could we modify, or just remove this for now?
@Centril Centril added A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. I-nominated labels Dec 31, 2019
@Centril
Copy link
Contributor

Centril commented Dec 31, 2019

cc @Zoxc @michaelwoerister

@jonas-schievink jonas-schievink added A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. labels Dec 31, 2019
@JohnTitor JohnTitor mentioned this issue Jan 1, 2020
Merged
@michaelwoerister
Copy link
Member

If the test fails, it indicates that there's a bug to be fixed. I'll try to reproduce.

@michaelwoerister michaelwoerister self-assigned this Jan 2, 2020
@Centril Centril added the P-high High priority label Jan 2, 2020
@pnkfelix
Copy link
Member

pnkfelix commented Jan 2, 2020 •
edited
Loading

triage: P-high, removing nomination

@michaelwoerister michaelwoerister mentioned this issue Jan 3, 2020
Merged
@mati865 mati865 mentioned this issue Jan 3, 2020
Merged
bors added a commit that referenced this issue Jan 3, 2020
@bors
Auto merge of #67829 - michaelwoerister:try-to-fix-pgo-branch-weights…
e845e69 
…-test, r=Mark-Simulacrum

Attempt to fix intermittent failures of pgo-branch-weights test.

This PR tries to fix the intermittent failures of the pgo-branch-weights test (#67746). The failing instances show no `!prof` annotations in LLVM IR. One possible cause is that the instrumented binary did not record anything. This is something I've occasionally seen happen for similarly small programs when using GNU ld as linker. The linker would not properly append the instruction counter sections, leading to most counters being dropped. This PR makes the test use the Gold linker instead.

It also makes each command exit immediately on failure so we can pinpoint the failure source better, should there still be a problem.

r? @Mark-Simulacrum
@pietroalbini pietroalbini removed the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jan 7, 2020
@michaelwoerister
Copy link
Member

Has this issue occurred since the potential fix in #67829 landed?

@JohnTitor
Copy link
Member Author

JohnTitor commented Jan 13, 2020 •
edited
Loading

I've not seen the failure recently. Should we close then?

@michaelwoerister
Copy link
Member

I think that's in order, yes. We can re-open if the issue re-appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelwoerister michaelwoerister

Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pnkfelix @Centril @jonas-schievink @michaelwoerister @pietroalbini @JohnTitor