Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement deriving for DeepClone #6514

Closed
thestinger opened this issue May 15, 2013 · 2 comments
Closed

implement deriving for DeepClone #6514

thestinger opened this issue May 15, 2013 · 2 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@thestinger
Copy link
Contributor

This should be pretty easy, it will just be the same as deriving for Clone (src/libsyntax/ext/deriving/clone.rs) but will use the DeepClone implementation of the fields/variants. Of course, it would be nice to factor out the duplicate code too.
@huonw
Copy link
Member

huonw commented May 15, 2013

Working on this.

huonw added a commit to huonw/rust that referenced this issue May 16, 2013
@huonw
syntax: implement #[deriving(DeepClone)]. Fixes rust-lang#6514.
cd2eb47
@thestinger
Copy link
Contributor Author

Fixed by #6530.

flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 11, 2022
@bors
Auto merge of rust-lang#8694 - Jarcho:check_proc_macro, r=xFrednet
10853f7 
More proc-macro detection

fixes rust-lang#6514
fixes rust-lang#8683
fixes rust-lang#6858
fixes rust-lang#6594

This is a more general way of checking if an expression comes from a macro and could be trivially applied to other lints. Ideally this would be fixed in rustc's proc-macro api, but I don't see that happening any time soon.

changelog: FPs: [`unit_arg`] [`default_trait_access`] [`missing_docs_in_private_items`]: No longer trigger in code generated from proc-macros.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huonw @thestinger