Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolstate for Linux not correctly published #63190

Closed
RalfJung opened this issue Aug 1, 2019 · 2 comments · Fixed by #63191
Closed

Toolstate for Linux not correctly published #63190

RalfJung opened this issue Aug 1, 2019 · 2 comments · Fixed by #63191
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Aug 1, 2019

The toolstate for Linux at https://rust-lang-nursery.github.io/rust-toolstate/ claims that tools are still failing. E.g., #63141 landed, but only the Windows toolstate was considered fixed after that.

Looks like something is breaking publishing Linux toolstate?

Cc @pietroalbini @kennytm
@pietroalbini
Copy link
Member

Apparently the publish environment variable is not properly propagated to the Linux builder...

@jonas-schievink jonas-schievink added C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 1, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Aug 1, 2019 •
edited
Loading

The build log for that Miri PR shows the right JSON:

{"nomicon":"test-pass","rls":"test-pass","embedded-book":"test-pass",
"edition-guide":"test-pass","rustbook":"test-fail","clippy-driver":"test-pass",
"miri":"test-pass","reference":"test-pass","book":"test-pass",
"rust-by-example":"test-pass","rustfmt":"test-pass"}

I cannot see an error message anywhere.

@pietroalbini pietroalbini mentioned this issue Aug 1, 2019
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this issue Aug 1, 2019
@pietroalbini
Rollup merge of rust-lang#63191 - pietroalbini:really-fix-toolstate, …
b1d5e52 
…r=alexcrichton

ci: fix toolstate not pushing data for Linux

A recent commit modified toolstate to only push updated data when the `TOOLSTATE_PUBLISH` environment variable is present. This worked fine on Windows but failed on Linux, since Linux jobs run inside Docker containers and the variable wasn't forwarded inside it.

This changes the Docker startup code to set the `TOOLSTATE_PUBLISH` enviornment variable inside the container if it's present outside.

r? @alexcrichton
fixes rust-lang#63190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix toolstate not pushing data for Linux pietroalbini/rust
3 participants
@RalfJung @jonas-schievink @pietroalbini