New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable LLVM and debug assertions for slow builders #59637

Open

alexcrichton opened this issue Apr 2, 2019 · 11 comments

Labels

O-macos P-low T-infra

Member

alexcrichton commented Apr 2, 2019 •

edited by Mark-Simulacrum

Loading

Assertions are currently disabled on a number of builders:

test-various - debug asserts, intentional - needed to properly test code size of some tests
dist-x86_64-apple - llvm, debug
dist-x86_64-apple-alt - llvm, debug
x86_64-apple - llvm, debug
dist-aarch64-apple - llvm, debug

alexcrichton mentioned this issue

ci: Disable llvm/debug assertions on x86_64-mingw #59638

Merged

pietroalbini added P-high T-infra labels

alexcrichton added a commit to alexcrichton/rust that referenced this issue


          ci: Disable llvm/debug assertions on x86_64-mingw

Tracked at rust-lang#59637 for re-enabling this commit disables assertions to
hopefully bring the runtime for this builder under control.

bors added a commit that referenced this issue


          Auto merge of #59638 - alexcrichton:less-assertions, r=pietroalbini

ci: Disable llvm/debug assertions on x86_64-mingw

Tracked at #59637 for re-enabling this commit disables assertions to
hopefully bring the runtime for this builder under control.

sanxiyn added the O-windows-gnu label

Member Author

alexcrichton commented Apr 5, 2019

For posterity, this had a pretty massive impact on CI times for the thre platforms that we disabled debug/llvm assertions for:

Member

aidanhs commented Apr 16, 2019

(currently waiting on a potential upgrade to our appveyor builder machines, maybe happening soonish)

pietroalbini added P-medium and removed P-high labels

mati865 mentioned this issue

Ship profiler with windows-gnu #61080

Merged

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn

c907f03

Ship profiler with windows-gnu

Fixes rust-lang#49409

I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637.

r? @michaelwoerister

P.S.
I have tested only x86_64 build.

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn

e6eaff6

Ship profiler with windows-gnu

Fixes rust-lang#49409

I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637.

r? @michaelwoerister

P.S.
I have tested only x86_64 build.

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn

1625abf

Ship profiler with windows-gnu

Fixes rust-lang#49409

I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637.

r? @michaelwoerister

P.S.
I have tested only x86_64 build.

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn

3674ed8

Ship profiler with windows-gnu

Fixes rust-lang#49409

I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637.

r? @michaelwoerister

P.S.
I have tested only x86_64 build.

Centril added a commit to Centril/rust that referenced this issue


          Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn

94b29f3

Ship profiler with windows-gnu

Fixes rust-lang#49409

I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637.

r? @michaelwoerister

P.S.
I have tested only x86_64 build.

bors added a commit that referenced this issue


          Auto merge of #61080 - mati865:mingw_pgo, r=sanxiyn

566f3d7

Ship profiler with windows-gnu

Fixes #49409

I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: #59637.

r? @michaelwoerister

P.S.
I have tested only x86_64 build.

mati865 mentioned this issue

Enable PGO tests on windows-gnu #61266

Open

Member

aidanhs commented Sep 3, 2019

Much has happened - we've migrated to azure in the meantime and our builds have got even slower, but there is potential to get 4 core machines there. Until then, this is still on hold.

alexcrichton added a commit to alexcrichton/rust that referenced this issue


          azure: Disable more LLVM/debug assertions in

821d293

This commit disables LLVM/debug assertions in our 5 slowest builders:

* i686-gnu
* i686-gnu-nopt
* i686-msvc-1
* i686-msvc-2
* x86_64-msvc-cargo

This is reducing the amount of test coverage for LLVM/debug assertions,
but we're just unfortunately running out of time on CI too many times.
Some test builds have shown that i686-gnu drops nearly an hour of CI
time by disabling these two assertions. Perhaps when we eventually get
4-core machines we can reenable these, but for now turn them off and
hook them up to the tracking issue at rust-lang#59637 which will ideally be
repurposes to tracking all of these.

alexcrichton mentioned this issue

azure: Disable more LLVM/debug assertions in #64517

Merged

pietroalbini changed the title ~~Re-enable LLVM and debug assertions for x86_64-mingw builder~~ Re-enable LLVM and debug assertions for slow builders

Member

pietroalbini commented Sep 17, 2019

#64517 also disabled LLVM assertions on the following builders:

i686-gnu
i686-gnu-nopt
i686-msvc-1
i686-msvc-2
x86_64-msvc-cargo

bors added a commit that referenced this issue


          Auto merge of #64517 - alexcrichton:less-assertions, r=pietroalbini

9150f84

azure: Disable more LLVM/debug assertions in

This commit disables LLVM/debug assertions in our 5 slowest builders:

* i686-gnu
* i686-gnu-nopt
* i686-msvc-1
* i686-msvc-2
* x86_64-msvc-cargo

This is reducing the amount of test coverage for LLVM/debug assertions,
but we're just unfortunately running out of time on CI too many times.
Some test builds have shown that i686-gnu drops nearly an hour of CI
time by disabling these two assertions. Perhaps when we eventually get
4-core machines we can reenable these, but for now turn them off and
hook them up to the tracking issue at #59637 which will ideally be
repurposes to tracking all of these.

Member

shepmaster commented Nov 5, 2019

Triage: Nothing has materially changed; we still don't have the time budget to re-enable these. Perhaps when the builders gain more cores.

Member

pietroalbini commented Dec 3, 2019

We'll probably want to re-enable those if we switch to GitHub Actions, as we have the time budget there.

Mark-Simulacrum self-assigned this

Member

Mark-Simulacrum commented Aug 5, 2020

With GHA, we should now have capacity to do this on CI. I will be posting a PR doing so soon.

Mark-Simulacrum mentioned this issue

Re-enable debug and LLVM assertions #75199

Merged

richkadel mentioned this issue

Working expression optimization, and some improvements to branch-level source coverage #78267

Merged

bors added a commit to rust-lang-ci/rust that referenced this issue


          Auto merge of rust-lang#75199 - Mark-Simulacrum:debug-asserts, r=piet…

b2d115f

…roalbini

Re-enable debug and LLVM assertions

Historically we've disabled these assertions on a number of platforms with the
goal of speeding up CI. Now, though, having migrated to GitHub actions, CI is
already pretty fast, and these debug assertions do bring us some value.

This does leave in some debug assertions that are performance-related: macOS
currently hovers at just under 2 hours.

There are also some other builders which have debug and LLVM assertions
disabled:

llvm-8, PR builder:

In one view, this builder tests our support for older LLVMs. But in reality, a
lot of our tests already disable themselves on older LLVMs, and I think our
general stance is that we really only support the in-tree LLVM. Plus, we really
want CI times on this builder to be really low, as it's run on *every* PR --
that's a lot of CI time.

test-various:

This disables debug asserts still -- as noted in the Dockerfile, we test code
size, and we need debug asserts off for that to work well.

Helps with rust-lang#59637 -- but doesn't close it, macOS still has asserts off.

r? `@pietroalbini`

Mark-Simulacrum added O-macos and removed O-windows-gnu labels

Member

Mark-Simulacrum commented Dec 16, 2020

Updated issue description, only macOS builders remain disabled.

phil-opp mentioned this issue

error: linker rust-lld not found #52362

Closed

shepmaster added P-low and removed P-medium labels

Member

shepmaster commented Aug 2, 2021

Since this now deals with just the macOS builders, there's not much we can do at the moment. It would likely require some external factor, such as GitHub Actions drastically improving the performance of those machines.

Contributor

nikic commented Aug 2, 2021

The issue lists a few dist-* targets, but shouldn't assertions always be disabled for those, regardless of capacity?

Member

Mark-Simulacrum commented Aug 2, 2021

Yes, that seems correct - I think only alt dist builders are assert enabled today.

Mark-Simulacrum removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment