ICE on enumerations referred to by submodules (submodule is declared before enum)

[mstewartgallus]

WIth rust 0.6 master, and incoming, I get an internal compile error:

error: internal compiler error: node_id_to_type: no type for node `expr 0 as int  id=13)`

This is a simple test case that reproduces the error:

pub mod buffer_binding {
   use super::BufferType;

   pub struct Context { handle : BufferType }
}

pub enum BufferType {
   ArrayBuffer = 0 as int
}

Strangely, the error only happens when the enumeration is defined after the submodule.

[Aatch]

Still valid.

Nominating for a milestone.

[huonw]

This appears to be an interaction between the as int and the submodule specifically, i.e. removing either of them makes it compile without issue.

[graydon]

accepted for production-ready milestone

[ghost]

this still happens with 69e46f3 from master.

But thx for the workaround Aatch

[jld]

#9942 looks like it might be a duplicate of this issue.

[jfager]

I've been digging into this a little bit. The direct problem on the non-compiling case given is that a cast expression needs more information than is currently available when check_item is called for the Context struct.

The lookup that's failing is

let ety = tcx.expr_ty(e);

in the ExprCast arm of middle::const_eval::eval_const_expr_partial, which is getting called via check_struct -> check_instantiable -> is_instantiable -> subtypes_require (ty_enum case) -> enum_variants.

I can make the sample code compile if I add

match variant.node.disr_expr {
    Some(e) => write_ty_to_tcx(tcx, e.id, result_ty),
    _ => {}
}

to the end of middle::typeck::collect::get_enum_variant_types and then pad out the inner case list on the ExprCast arm of middle::const_eval::eval_const_expr_partial to:

ty::ty_int(_) | ty::ty_bool | ty::ty_enum(_,_) => {

I'm pretty doubtful this is the right solution, it's just a hack to highlight the issue.

As far as why slight variations work:

• If the cast is removed, the code compiles because we hit the ExprLit arm of eval_const_expr_partial instead of ExprCast.
• If the enum is placed before the mod block, the code compiles because check_item gets called on the enum before it gets called on the struct, which has the side effect of putting all the right ids into the type context.

It seems like the "right" answer would be ensuring that enums are checked before things that use them, but figuring out how to do that is still a bit out of my depth.