Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Pinning documentation #58130

Closed
RalfJung opened this issue Feb 3, 2019 · 1 comment
Closed

Expand Pinning documentation #58130

RalfJung opened this issue Feb 3, 2019 · 1 comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@RalfJung
Copy link
Member

RalfJung commented Feb 3, 2019 •
edited
Loading

In #55766, it was determined that pinning should be better documented before being stabilized. Yet, stabilization happened without resolving many of the documentation concerns spelled out or writing down the answer given in

Cc @cramertj @withoutboats
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Feb 3, 2019
@RalfJung RalfJung mentioned this issue Feb 19, 2019
Merged
@RalfJung
Copy link
Member Author

I am proposing expanded documentation in #58574, please help proof-reading that!

bors added a commit that referenced this issue Feb 22, 2019
@bors
Auto merge of #58574 - RalfJung:pin, r=Mark-Simulacrum
c6fd027 
improve Pin documentation

Incorporates a bunch of the documentation-related comments that came up when discussing `Pin` stabilization.

Cc @alexcrichton @withoutboats @cramertj @jonhoo

Fixes #58130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RalfJung @jonas-schievink