-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run-make-fulldeps/c-link-to-rust-va-list-fn fails on aarch64-linux-gnu #56475
Comments
We rely on the LLVM implementation of |
BTW thanks for testing and reporting this! |
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) simd-intrinsic-generic-bitmask.rs: broken on BE, rust-lang#59356 simd-intrinsic-generic-select.rs: broken on BE, rust-lang#59356 sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) simd-intrinsic-generic-bitmask.rs: broken on BE, rust-lang#59356 sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) simd-intrinsic-generic-bitmask.rs: broken on BE, rust-lang#59356 sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) simd-intrinsic-generic-bitmask.rs: broken on BE, rust-lang#59356 sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
I had a brief conversation with @parched yesterday regarding this issue, and picking up the pull request that was opened. The following comment #62207 (review) about some platforms using the va_arg instruction and some using rust generated LLVM IR. Does the rust community now have a preference as to how to handle va_args as that comment was made almost a year ago? I think there is more benefit in fixing up the va_arg instruction within LLVM. But I would like to get this issue fixed in a way that is approved by the rust community. |
Awesome! Excited to see some interest in this. I've recently had some conversations with co-workers about work on this as well.
Do you mean within the rustc codegen or upstream LLVM? |
I was thinking upstream LLVM. I thought it would be best to raise the question here though as there didn't seem to be a decision on your comment about if rust was going to standardise it's approach to this, and if it is then which approach it would be. |
Last I checked there didn't seem to be much interest in this and it would require a quite large effort.
IMHO a non-standarrd solution is better than a broken one 😄 My first implementation of Aarch64 variadics is broken, so I'd love to get something merged whether or not it is entirely standard. That being said, if we can implement this in codegen, I'd greatly prefer that. |
I have had a look at implementing this in rustc_codegen_llvm and started on this so if you want to assign it to me I'll continue on. |
va_args implementation for AAPCS. Implement the va args in codegen for AAPCS, this will be used as the default va_args implementation for AArch64 rather than the va_args llvm-ir as it currently is. This should fix the following issues: rust-lang#56475 rust-lang#72579
va_args implementation for AAPCS. Implement the va args in codegen for AAPCS, this will be used as the default va_args implementation for AArch64 rather than the va_args llvm-ir as it currently is. This should fix the following issues: rust-lang#56475 rust-lang#72579
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) simd-intrinsic-generic-bitmask.rs: broken on BE, rust-lang#59356 sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
c-link-to-rust-va-list-fn: unstable feature, broken on aarch64, rust-lang#56475 env-funky-keys: can't handle LD_PRELOAD (e.g. sandbox) long-linker-command-lines: takes >10 minutes to run (but still passes) sparc-struct-abi: no sparc target sysroot-crates-are-unstable: can't run rustc without RPATH
Running
python2.7 ./x.py test --stage 2
onaarch64-linux-gnu
I end up with the following failureI was building this commit 9cd3bef
I haven't had the chance to debug it yet but I'll take a look when I get a chance.
cc @dlrobertson
The text was updated successfully, but these errors were encountered: