Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-make-fulldeps/hotplug_codegen_backend is too presumptuous in checking for its dependencies #56222

Closed
nagisa opened this issue Nov 25, 2018 · 0 comments · Fixed by #118899
Closed

run-make-fulldeps/hotplug_codegen_backend is too presumptuous in checking for its dependencies #56222

nagisa opened this issue Nov 25, 2018 · 0 comments · Fixed by #118899
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@nagisa
Copy link
Member

nagisa commented Nov 25, 2018

Namely, it has

	/bin/echo || exit 0 # This test requires /bin/echo to exist

however, it is not guaranteed that this binary will be exactly at /bin/echo on all systems. For example it isn’t on mine:

which echo # /run/current-system/sw/bin/echo
ls /bin/ | grep echo; or echo "echo is not in /bin/" # echo is not in /bin/
@nagisa nagisa added the A-testsuite Area: The testsuite used to check the correctness of rustc label Nov 25, 2018
@Enselic Enselic added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Nov 20, 2023
@veera-sivarajan veera-sivarajan mentioned this issue Dec 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 1, 2024
@bors
Auto merge of rust-lang#118899 - veera-sivarajan:fix-makefile, r=Mark…
478d825 
…-Simulacrum

fix(tests): remove check for `echo`

fixes: rust-lang#56222

Removes check for `echo` as it doesn't seem to be used anywhere.
@bors bors closed this as completed in 8d39ec1 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tests): remove check for echo veera-sivarajan/rust
2 participants
@Enselic @nagisa